Studiologic SL Keyboard display - display 5 doesn't show text

[gofer723]

As described in the "Announcing ReaLearn" thread: https://forum.cockos.com/showpost.php?p=2701362&postcount=3631
Display 5 of this MIDI source doesn't show any text.

I found that the SysEx messages sent to either line of this particular section of SL display does contain the correct addresses, but not the actual text part.

I assume the issue lies in the following lines in (what I think would be) midi_source.rs, committed on Sep 11, 2022 "#670 Add support for SL88 keyboard display":
lines 1863 - 1880

mpl SlKeyboardDisplayDestination {
    pub fn new(section_index: u8, line_index: u8) -> Self {
        Self {
            section_index,
            line_index,
        }
    }

    pub fn line_length(&self) -> u8 {
        match (self.section_index, self.line_index) {
            (0, 0) => 13,
            (1..=3, 0) => 10,
            (1..=3, 1) => 9,
            _ => 0,
        }
    }
}

Proposing that lines 1874/1875 might have a numbering mistake and should possibly be:

(1..=4, 0) => 10,
(1..=4, 1) => 9,

I really hope that this simple change would solve the issue,

thanks (I feel kinda uncanny about sniffing around in your code and proposing changes, I must say... After all I am a total noob and you coded this masterpiece of a software)

[helgoboss]

Hi gofer, thanks for the report. Currently, I'm not at home so I can't experiment with the actual SL keyboard. Yes, it's quite possible that I made a mistake in the lines you pointed out. If you want, you can check it by building the project yourself. In addition to the instructions in CONTRIBUTING.md, you might want to check out the correct version tag (the tip of the master branch is in a state of flux at the moment).