💻 new customize adventure page #5535
Conversation
…o new-customize-adventure
…o new-customize-adventure
…mple - needed changes
…o new-customize-adventure
|
@Felienne as discussed in the meeting, we need to decide what descriptions we want to put in the solution example and tips tabs:
|
There was a problem hiding this comment.
Hi! Felienne told me to review this since she's busy.
Seeing the UI I think that the Preview button might be made available on the "Adventure" tab, rather than in the General settings one. I also think the "I agree that my adventure might be made publicly available on Hedy." section can be switched over to the settings tab.
On the solution example section we can put something like:
This is where the solution of your adventure goes. This can be used if you want to share this adventure with other teacher's, so they can know what your suggested solution is.
If both of these tabs have the editor, maybe we can add the help button to both of them as well
|
@jpelay I like and agree with all suggestions! |
|
Will disable the tips section for now until it's needed and known what content to put in there! |
Disabling seems a bit of a heavy strategy? |
I think we want something along the lines of: "Here you can add tips to help other teachers help their students"? |
Sure. How would creating tips look like? Where and how do we list or represent them?
I didn't get any note about it!! Also i thought we could implement it in a separate PR in accordance with the new hedy design that's being created! |
I am lost here, sorry. In the screenshot above, there is already a tab called "tips". I thought you were looking for text to put there to expain what the tips are for. Help me understand what text you need and I can provide it to you. Please remember I have not looked at this PR, so if you need my input, you need to sketch a bit of context and ask me clear questions (Or ask Jesus, he has seen more of this work, and I am sure he has great ideas too!)
I think this has to do with the fact that I don't really understand the question well (again, I have not looked at the PR, just jumping in for being tagged) But surely we can do it in a different PR is that makes more sense, just open an issue so we don't forget. |
There was a problem hiding this comment.
Hey @hasan-sh ! Looks good, I've added a few comments and was wondering, is the whole page covered in the Cypress tests now?
And on a whole different note, I don't really agree with the design of the tabs. Not only because the new design for the Hedy tabs is not implemented yet, so until then teachers might be very confused. But still I think this can be done in a more understandable way. @Felienne @gisellandrade what do you think? Just addressing this now, but can of course be done in a different PR.
tests/cypress/e2e/for-teacher_page/customize-adventure_page/tags.cy.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/for-teacher_page/customize_class_page/customize_class.cy.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/for-teacher_page/customize_class_page/customize_class.cy.js
Outdated
Show resolved
Hide resolved
- added a submit button - changed levels label to level.
…o new-customize-adventure
Hi @Annelein! Do you want to make changes to these tabs (that are a bit different from the adventure tabs, because they are here representing different aspects of an adventure)? I am open to looking at what you want it to look like, but I can also imagine we redesign this with the new homepage together. |
Hi @Felienne ! I think it should be a different than the adventure tabs design, so not redesign it with the homepage but septeratly. Because these aren't adventure tabs but they have a whole different meaning/purpose right? Let me know if you get what I mean. I was thinking something like this for example: |
I like this since it aligns more with the new redesign, do you wanna push your commit here before we merge? |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5086