-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charts: Add a values schema #1926
Comments
Thank you for creating the issue. Working on this |
knrt10
added a commit
that referenced
this issue
Jun 3, 2024
Charts did not have defined structure for Headlamp value configurations. Now we have defined schema for the same which will run while linting, installing, upgrading or templating the helm charts. Fixes: #1926 Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
added a commit
that referenced
this issue
Jun 3, 2024
Charts did not have defined structure for Headlamp value configurations. Now we have defined schema for the same which will run while linting, installing, upgrading or templating the helm charts. Fixes: #1926 Signed-off-by: Kautilya Tripathi <[email protected]>
skoeva
pushed a commit
that referenced
this issue
Jun 21, 2024
Charts did not have defined structure for Headlamp value configurations. Now we have defined schema for the same which will run while linting, installing, upgrading or templating the helm charts. Fixes: #1926 Signed-off-by: Kautilya Tripathi <[email protected]>
skoeva
pushed a commit
that referenced
this issue
Jun 26, 2024
Charts did not have defined structure for Headlamp value configurations. Now we have defined schema for the same which will run while linting, installing, upgrading or templating the helm charts. Fixes: #1926 Signed-off-by: Kautilya Tripathi <[email protected]>
joaquimrocha
pushed a commit
that referenced
this issue
Jun 26, 2024
Charts did not have defined structure for Headlamp value configurations. Now we have defined schema for the same which will run while linting, installing, upgrading or templating the helm charts. Fixes: #1926 Signed-off-by: Kautilya Tripathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It was mentioned here #1897 to take a look at the bitnami charts for postgresql.
The have some docs https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L1635
Also they have a values.schema.json https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.schema.json
So this issue is about adding a values.schema.json JSON schema file.
https://helm.sh/docs/topics/charts/#schema-files
https://medium.com/@hans.knechtions/6-tips-to-writing-a-great-helm-chart-35899b00a6cc
This would help people use the headlamp chart, by validating the user input.
Additionally, on artifact hub one of the quality badges is missing because it does not use a values schema.
The text was updated successfully, but these errors were encountered: