Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run mypy_primer on pull requests #27

Open
sobolevn opened this issue Jan 20, 2022 · 2 comments
Open

Run mypy_primer on pull requests #27

sobolevn opened this issue Jan 20, 2022 · 2 comments

Comments

@sobolevn
Copy link
Contributor

I guess that it is a good idea to run priper, when the source code changes.
This might catch possible regressions in the future.

@hauntsaninja
Copy link
Owner

Thanks, yeah, running more stuff in CI is a good idea, but I'm not sure what exactly.

When adding or changing projects, the thing that is most valuable is the "full" output (you need the full output because e.g. if you misconfigure and there's zero output, the diff is also zero). But "full" output is very verbose across all 100 projects — maybe we need a primer for primer output :-)

For what it's worth, I usually just test locally with mypy_primer -k new_project --debug.

@hauntsaninja
Copy link
Owner

#28 (comment) is a good example of needing to see the full output to know things are broken :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants