How to disable type signatures in instances?

[hellwolf]

After a recent hls update, the type signatures in the instances are cluttering my Emacs editor:

I often accidentally click them and it would add instance sig for me, I'd prefer not seeing them.

Thank you in advance!

[jhrcek]

Look for a way to disable "class plugin" in your editor.
Sorry for answering question you didn't ask, but here's how this can be done in vscode:

disable_class_plugin.mp4

[July541]

Hello @hellwolf, sorry for bothering you.

You can disable it by "haskell.plugin.class.codeLensOn": false in vscode, not sure about other editors. Run haskell-language-server generate-default-config may have some hints.

BTW, you can query all settings by haskell-language-server vscode-extension-schema, and further information can be found at https://haskell-language-server.readthedocs.io/en/latest/configuration.html

[hellwolf]

Thank you @jhrcek and @July541 !

Since I am using emacs, I am trying to figure out a way myself:

lsp-haskell-plugin-class-global-on definitely worked for me, but trying to disable codeLensOn failed so far, I will dig a bit more details later. Maybe some emacs user could see this message and comment what I am doing wrong:

(EDIT: WRONG CODE)

(use-package lsp-haskell
  :config
  (add-hook 'lsp-after-initialize-hook
          (lambda ()
            (lsp--set-configuration
              '(:haskell (:plugin (:class (:codeLensOn false))))
              ))))

[hellwolf]

Just wanted to say that I like the feature, just that the clutterness and the fact clicking it accidentally sometimes modifies the code is a bit undesired.

Thank you for all your works, I enjoy it a lot using emacs.

[July541]

@hellwolf From https://github.com/emacs-lsp/lsp-haskell#configuration, maybe

(use-package lsp-haskell
  :config
  (add-hook 'lsp-after-initialize-hook
          '(lambda () ;; note here
            (lsp--set-configuration
              '(:haskell (:plugin (:class (:codeLensOn false))))
              ))))

Just from an amateur of emacs.

[hellwolf]

that one definitely helped, but now I need to fight for the "false" being string issue

[hellwolf]

I think I found the right combination:

(use-package lsp-haskell
  :config
  (add-hook 'lsp-after-initialize-hook
            #'(lambda ()
                (lsp--set-configuration
                 '(:haskell (:plugin (:class (:codeLensOn nil))))
                 ))))

:)

EDIT: still didn't work

[hellwolf]

I will report to lsp-mode my experience, maybe they could make it different. I am not sure how vscode experience is.

[July541]

I am not sure how vscode experience is.

I am sure about adding "haskell.plugin.class.codeLensOn": false to config file is enough :)

[hellwolf]

Btw, I am using "master" branch of the hls compiled last week.

[July541]

I can't find a better solution in a short term, someone who has ideas are welcome :)

[July541]

Your lenses are cluttered indeed, they need a better UI like it in vscode.

[hellwolf]

Do you not accidentally click those type signatures? What happens in vscode if you clicked them?

[July541]

vscode will also insert a signature. I seldom click it by mistake and I use the keyboard to navigate the code.

[michaelpj]

I'm surprised that the lenses are appearing to the right of the definition, rather than above them like they do for other type signature lenses. Is that intended @July541 ?

[michaelpj]

Hmm, in @jhrcek 's video of vscode they're appearing above. Something is strange there. Maybe emacs interprets the position differently? Are we sending something weird?

[July541]

I'm surprised that the lenses are appearing to the right of the definition, rather than above them like they do for other type signature lenses.

Me too. I just thought it is how emacs implement code lens, look not?

They should be displayed above the code. But how to render the lens relies on editor's implementation.

[michaelpj]

@hellwolf could you give us the logs of a session showing the type lens responses. And can you see if you get the same behaviour as @jhrcek in vscode?

[hellwolf]

https://pastebin.com/afFTQTfD

[hellwolf]

@michaelpj let me know if this helps

[July541]

It looks like little info is available, I'd love to see the log from emacs session while rendering lsp requests.

Indeed, we should log the position info for lens, but it doesn't help for editor's difference...

[michaelpj]

Okay, now I can reproduce this!

[michaelpj]

I'll try and get a session log and make a proper issue.

[hellwolf]

Looking forward to, definitely want to learn also of how to be a contributor, using this opportunity...

[michaelpj]

All the code lenses were doing this, so I had a look and I found this in the lsp-mode changelog:

Add lsp-lens-place-position with option to place code lens at end of line as default.

So that explains the placement to the right, which was mysterious. As for turning them off, I think that's answered already.

[hellwolf]

Yes

  (lsp-lens-place-position 'above-line)

Works!

Thanks @michaelpj .

I should look into changelog first next!

[hellwolf]

Actually the real annoyance is still that I sometimes accidentally clock into those "code lenses" then it creates those code for me...

[michaelpj]

Sure, but you can turn them off.

[hellwolf]

oh, I have been trying to find how, could you please hint where can I find the option for that?

[July541]

Unfortunately, you can only disable the lens instead of disabling the clicking action...

But we can replace the lens with inlay hints in the future. #2938 (comment)