Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Eq instance for Matrix with degenerate matrices #367

Open
nasosev opened this issue Mar 9, 2023 · 2 comments
Open

Problem with Eq instance for Matrix with degenerate matrices #367

nasosev opened this issue Mar 9, 2023 · 2 comments

Comments

@nasosev
Copy link

nasosev commented Mar 9, 2023

Example:

size ((0><0) []) == size ((1><0) []) -- False

yet,

((0><0) []) == ((1><0) []) -- True 
@HuwCampbell
Copy link
Collaborator

Interestingly

((0><1) []) == ((0><0) []) == False

The code in question is this:

equal a b = cols a == cols b && flatten a `equal` flatten b

it should probably be

equal a b = rows a == rows b && cols a == cols b && flatten a `equal` flatten b

@nasosev
Copy link
Author

nasosev commented Nov 2, 2023

@HuwCampbell is this likely to be fixed any time soon? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants