Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add an option to retrieve rest of the secrets if others are missing #406

Open
pgmanutd opened this issue Jan 11, 2023 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@pgmanutd
Copy link

Is your feature request related to a problem? Please describe.
I tried using multiple secrets, but if one of the secret paths is wrong or the key is missing, other secrets are also not retrieved. Entire job fails. In our case, we were retrieving a secret and slack url. Since the secret path was wrong, the slack url was also not retrieved and the message never got posted in the slack channel.

Describe the solution you'd like
I am not sure if we should fail the entire job or not. Maybe if all the keys are wrong then fail. Or add a not required option for this.

Describe alternatives you've considered
Make sure the secret path is correct and it is present in the vault.

Additional context
None

@pgmanutd pgmanutd added the enhancement New feature or request label Jan 11, 2023
@akshaychopra5207
Copy link

Anybody working on it or do we have some workaround. if not we can try to work on it?

@fairclothjm
Copy link
Contributor

@pgmanutd I can see the value in an enhancement like this. I will bring it up with the team to see if this is something we want to do.

@akshaychopra5207
Copy link

@fairclothjm How long it can take to add this enhancement. We would need to decide to use this or write our own. Is there anything I can help with?

@fairclothjm
Copy link
Contributor

@akshaychopra5207 Hi, I have a branch that implements the feature. It needs unit and e2e tests added and maybe some more testing and verification. Unfortunately, I don't have cycles to work on it at this time. If you or anyone else wanted to pick it up from there I would help to review it and get it merged.

@ndegwamartin
Copy link

Did we already get a way forward on this?

@ndegwamartin
Copy link

@akshaychopra5207 the branch link you shared loads an empty diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants