Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Proxy configuration #138

Open
pzamoran opened this issue Oct 19, 2020 · 5 comments · May be fixed by #374
Open

[FEAT] Proxy configuration #138

pzamoran opened this issue Oct 19, 2020 · 5 comments · May be fixed by #374
Labels
enhancement New feature or request

Comments

@pzamoran
Copy link

Is your feature request related to a problem? Please describe.
My current problem is related with runners running inside isolated networks using proxy to connect to Internet. Node is not configured or I don't know how to configure to use the system proxy.

Describe the solution you'd like

  • Include new variables to add proxy configuration. By default empty.
@pzamoran pzamoran added the enhancement New feature or request label Oct 19, 2020
@RichiCoder1
Copy link
Contributor

Interesting, it does looks Vault Action does indeed need to take extra steps to support proxies: https://github.com/sindresorhus/got#proxies

@Xplouder
Copy link

Xplouder commented Apr 5, 2022

bump

@clarktlaugh
Copy link

clarktlaugh commented Aug 10, 2022 •
edited

Has there been any developments on this? I am running into the same issue. I can access our vault deployment using curl with proper proxy EVs set, but hashicorp/vault-action does not work. Proxy support is supposed to be available in @actions/http-client provided by https://github.com/actions/toolkit. Any chance that can be leveraged?

@depatl
Copy link

depatl commented Oct 12, 2022

bumping this up. is there any progress on this?

@clarktlaugh
Copy link

I submitted a PR today to add support: #374

@clarktlaugh clarktlaugh linked a pull request Nov 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add proxy support using hpagent clarktlaugh/vault-action
5 participants
@RichiCoder1 @clarktlaugh @Xplouder @depatl @pzamoran