Add AllDiag and AnyDiag to helper/validation for combining SchemaValidateDiagFunc
#1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangasta
commented
Feb 28, 2023
kangasta
force-pushed
the
validation-diag-all-any
branch
from
fbc5b17 to
d5c08b7
Compare
bflad
approved these changes
Aug 29, 2023
Comment on lines
+2
to
+3
| body: Add `SchemaValidateDiagFunc` variants of helper/validation `All` and `Any` as | ||
| `AllDiag` and `AnyDiag`. |
There was a problem hiding this comment.
Suggested change
| body: Add `SchemaValidateDiagFunc` variants of helper/validation `All` and `Any` as | |
| `AllDiag` and `AnyDiag`. | |
| body: 'helper/validation: Added `AllDiag` and `AnyDiag`, which are `SchemaValidateDiagFunc` | |
| variants of `All` and `Any`' |
|
Looks like I cannot merge the suggestion into this PR, so will make that change post-merge. |
bflad
added a commit
that referenced
this pull request
Aug 29, 2023
bflad
added a commit
that referenced
this pull request
Aug 30, 2023
techknowlogick
pushed a commit
to go-gitea/terraform-provider-gitea
that referenced
this pull request
Sep 8, 2023
… to v2.29.0 (#17) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) | require | minor | `v2.27.0` -> `v2.29.0` | --- ### Release Notes <details> <summary>hashicorp/terraform-plugin-sdk (github.com/hashicorp/terraform-plugin-sdk/v2)</summary> ### [`v2.29.0`](https://github.com/hashicorp/terraform-plugin-sdk/releases/tag/v2.29.0) [Compare Source](hashicorp/terraform-plugin-sdk@v2.28.0...v2.29.0) NOTES: - all: This Go module has been updated to Go 1.20 per the [Go support policy](https://go.dev/doc/devel/release#policy). It is recommended to review the [Go 1.20 release notes](https://go.dev/doc/go1.20) before upgrading. Any consumers building on earlier Go versions may experience errors. ([#​1245](hashicorp/terraform-plugin-sdk#1245)) FEATURES: - helper/schema: Upgrade to protocol version 5.4, which can significantly reduce memory usage with Terraform 1.6 and later when a configuration includes multiple instances of the same provider ([#​1234](hashicorp/terraform-plugin-sdk#1234)) ENHANCEMENTS: - helper/validation: Added `AllDiag` and `AnyDiag`, which are `SchemaValidateDiagFunc` variants of `All` and `Any` ([#​1155](hashicorp/terraform-plugin-sdk#1155)) - helper/validation: Added quoting in `StringInSlice` error diagnostic output to prevent confusion with values that contain spaces ([#​464](hashicorp/terraform-plugin-sdk#464)) ### [`v2.28.0`](https://github.com/hashicorp/terraform-plugin-sdk/releases/tag/v2.28.0) [Compare Source](hashicorp/terraform-plugin-sdk@v2.27.0...v2.28.0) NOTES: - helper/schema: The `Resource` type `EnableApplyLegacyTypeSystemErrors` and `EnablePlanLegacyTypeSystemErrors` fields can be enabled to more easily discover resource data consistency errors which Terraform would normally demote to warning logs. Before enabling the flag in a production release for a resource, the resource should be exhaustively acceptance tested as there may be unrecoverable error situations for practitioners. It is recommended to first enable and test in environments where it is easy to clean up resources, potentially outside of Terraform. ([#​1227](hashicorp/terraform-plugin-sdk#1227)) ENHANCEMENTS: - helper/schema: Added `Resource` type `EnableLegacyTypeSystemApplyErrors` field, which will prevent Terraform from demoting data consistency errors to warning logs during `ApplyResourceChange` (`Create`, `Update`, and `Delete`) operations with the resource ([#​1227](hashicorp/terraform-plugin-sdk#1227)) - helper/schema: Added `Resource` type `EnableLegacyTypeSystemPlanErrors` field, which can be used to prevent Terraform from demoting data consistency errors to warning logs during `PlanResourceChange` operations with the resource ([#​1227](hashicorp/terraform-plugin-sdk#1227)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43OS4xIiwidXBkYXRlZEluVmVyIjoiMzYuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://gitea.com/gitea/terraform-provider-gitea/pulls/17 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #780