Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM Builder: Windows builds default to SSH communicator type when communicator is unset #422

Open
JenGoldstrich opened this issue Jun 11, 2024 · 0 comments
Labels

Comments

@JenGoldstrich
Copy link
Contributor

JenGoldstrich commented Jun 11, 2024

Similar to #415

Whenever the communicator field is unset Windows will try to connect via SSH instead of WinRM, this fails because SSH on Windows is not configured to work by default.

This happens because of this logic in the packer-plugin-sdk https://github.com/hashicorp/packer-plugin-sdk/blob/9c1d2437dcbde2571b2a8f5d8ce280dce76a377b/communicator/config.go#L461-L463

To solve this either force users to specify a communicator, or forcibly override the default to WinRM for Windows builds, this would need to be done before this Prepare call

var errs *packersdk.MultiError
errs = packersdk.MultiErrorAppend(errs, c.Comm.Prepare(&c.ctx)...)

@JenGoldstrich JenGoldstrich changed the title Windows Builds Default to SSH when communicator is unset ARM Builder: Windows builds default to SSH communicator type when communicator is unset Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant