Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock/unlock files properly for Windows #3941

Open
PenguinKeeper7 opened this issue Jan 30, 2024 · 0 comments
Open

Lock/unlock files properly for Windows #3941

PenguinKeeper7 opened this issue Jan 30, 2024 · 0 comments

Comments

@PenguinKeeper7
Copy link
Contributor

Implementing a proper fix will allow better feature parity between Linux and Windows and may reduce future bugs. This code is 8 years old and isn't causing any known bugs but would be good practice to fix.
See comments: (fcntl is Linux-only)

hashcat/src/locking.c

Lines 49 to 61 in c1a1051

int hc_lockfile (MAYBE_UNUSED HCFILE *fp)
{
// we should put windows specific code here
return 0;
}
int hc_unlockfile (MAYBE_UNUSED HCFILE *fp)
{
// we should put windows specific code here
return 0;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant