Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use <abbr> tag #495

Open
asavartsov opened this issue Feb 14, 2012 · 1 comment · May be fixed by #2726
Open

Do not use <abbr> tag #495

asavartsov opened this issue Feb 14, 2012 · 1 comment · May be fixed by #2726
Labels
Has Solution

Comments

@asavartsov
Copy link

Nevermind that using semantic tags as decoration elements isn't a good practice, if some styles globally set for abbr tag, they affects chosen's selection clearing cross. To be specific, Bootstrap 2.0 defines some, so using bootstrap and chosen together means resetting abbr styles specifically for chosen.
@pfiller pfiller mentioned this issue Mar 19, 2014
Closed
@pfiller
Copy link
Contributor

pfiller commented Mar 19, 2014

From @mlettini in #1838

Not sure why we are using <abbr>, but it doesn't make sense in this context. We should probably use an <a> for the close button, since it takes an action on click, and that's the tag we use for .search-choice-close on Multi Chosen.

koenpunt added a commit that referenced this issue Oct 15, 2016
@koenpunt
use a tag instead of abbr tag for search-choice-close
1eec4b1 
fixes #495
@koenpunt koenpunt linked a pull request Oct 15, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Has Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use a tag instead of abbr tag for search-choice-close harvesthq/chosen
3 participants
@koenpunt @pfiller @asavartsov