Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to remove kotlin-reflect? #24

Open
kaushalyap opened this issue Dec 31, 2019 · 3 comments
Open

Any plan to remove kotlin-reflect? #24

kaushalyap opened this issue Dec 31, 2019 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@kaushalyap
Copy link

I see this library also uses kotlin-reflect just like MvRx,
problem with kotlin-reflect is impact on apk size. MvRx have come up with a solution. Any plan to remove kotlin-reflect from Vector?

@haroldadmin
Copy link
Owner

Hi @kaushalyap! Thanks for bringing up this issue.

Yep, Vector depends on kotlin-reflect. I really want to remove it too. I'll take a look at the PR you linked and try to perform everything Vector needs using plain old java-reflection. Not promising an ETA, though.

@haroldadmin haroldadmin added enhancement New feature or request question Further information is requested labels Dec 31, 2019
@kaushalyap
Copy link
Author

@haroldadmin thanks for quick response

Side question: do you consider Vector production ready?

@haroldadmin
Copy link
Owner

I use Vector in production in MoonShot, and I'm really happy with it. However, this project still hasn't hit 1.0 yet, so that should tell you where the API stability stands :)

For small apps and side projects, I'd definitely recommend at least trying it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants