Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hide Window Titlebar" doesn't seem to have any effect on GNOME 44 #324

Closed
rolaca11 opened this issue Apr 6, 2023 · 27 comments · May be fixed by #334
Closed

"Hide Window Titlebar" doesn't seem to have any effect on GNOME 44 #324

rolaca11 opened this issue Apr 6, 2023 · 27 comments · May be fixed by #334
Labels

Comments

@rolaca11
Copy link

rolaca11 commented Apr 6, 2023

Describe the bug
Enabling "Hide Window Titlebar" doesn't seem to have any effect on GNOME 44.

To Reproduce
Steps to reproduce the behavior:

  1. Install Fedora 38
  2. Enable "Hide Window Titlebar" (any option)
  3. Titlebars are unchanged

Expected behavior
Titlebars should disappear from apps, like Discord, or IntelliJ

Screenshots
image
image

Environment (please complete the following information):

  • OS: Fedora 38
  • GNOME Shell version: 44
  • Unite version: 70

Logs

-- Boot 6ab9025146134de3a9902d14bc677dc5 --
-- Boot 35f3854a5c7345f983ceba6a48482396 --
Apr 05 14:58:36 MiWiFi-R3600-srv gnome-software[10309]: Failed to run in transient scope: GDBus.Error:org.freedesktop.systemd1.UnitExists: Unit app-flatpak-org.gnome.Extensions-10309.scope was already loaded or has a fragment file.
-- Boot 59841b723fce46658761224cf87bd267 --
-- Boot 2abb1415dc1d4536a573bbfe9aeef1f2 --
Apr 06 08:42:55 MiWiFi-R3600-srv gnome-software[4659]: Failed to run in transient scope: GDBus.Error:org.freedesktop.systemd1.UnitExists: Unit app-flatpak-org.freedesktop.Platform.GL.nvidia\x2d530\x2d30\x2d02-4659.scope was already loade>
Apr 06 08:51:36 MiWiFi-R3600-srv gnome-software[4659]: Failed to run in transient scope: GDBus.Error:org.freedesktop.systemd1.UnitExists: Unit app-flatpak-ca.desrt.dconf\x2deditor-4659.scope was already loaded or has a fragment file.
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:    creating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/panel.js
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/layout.js
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/helper.js
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/window.js
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/prefs.js
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/settings.ui
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:    creating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/styles/
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/styles/spacing-classic.css
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/overrides/styles/spacing-legacy.css
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:    creating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/schemas/
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/schemas/org.gnome.shell.extensions.unite.gschema.xml
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:   inflating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/schemas/gschemas.compiled
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:    creating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/scripts/
Apr 06 08:57:14 MiWiFi-R3600-srv gnome-shell[9122]:    creating: /home/ropi/.local/share/gnome-shell/extensions/[email protected]/styles/
@jonian
Copy link
Member

jonian commented Apr 6, 2023

Hey @rolaca11, for flatpak apps check this #303 (comment)

@rolaca11
Copy link
Author

rolaca11 commented Apr 6, 2023

ohh looks like I made a mistake. IntelliJ isn't a flatpak app on my system and still is unaffected

@jonian
Copy link
Member

jonian commented Apr 15, 2023

How did you install IntelliJ? I have installed Fedora 38 in gnome-boxes and it has only flatpak version. Please provide the output of xprop for the IntelliJ window (type xprop in a terminal and then click on the IntelliJ window).

@emko
Copy link

emko commented Apr 19, 2023

yea same for me, i am on fedora 38 gnome 44 and both flatpak or native apps title bar always shows, on 43 it worked perfect

@rolaca11
Copy link
Author

Looks like I don't have the problem anymore in Ubuntu 23.04

@Barugon
Copy link

Barugon commented May 3, 2023

Having the same issue with Fedora 38.

@FallingLights
Copy link

@jonian

`_MOTIF_DRAG_RECEIVER_INFO(_MOTIF_DRAG_RECEIVER_INFO) = 0x6c, 0x0, 0x5, 0x0, 0x4c, 0x0, 0x0, 0x1, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, 0x0, 0x0
XdndAware(ATOM) = BITMAP
_GTK_EDGE_CONSTRAINTS(CARDINAL) = 170
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_NET_WM_DESKTOP(CARDINAL) = 0
_MUTTER_NEEDS_FRAME(CARDINAL) = 1
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
_NET_WM_USER_TIME(CARDINAL) = 3428717
_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL
_MOTIF_WM_HINTS(CARDINAL) = 2, 0, 2, 0, 0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_HORZ, _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_STATE_FOCUSED
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 74, 0
WM_HINTS(WM_HINTS):
Client accepts input or input focus: False
Initial state is Normal State.
_NET_WM_ICON(CARDINAL) = Icon (128 x 128):
(not shown)

_NET_WM_PID(CARDINAL) = 21241
WM_CLIENT_MACHINE(STRING) = "fedora-local"
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS
WM_CLASS(STRING) = "jetbrains-goland", "jetbrains-goland"
WM_CLIENT_LEADER(WINDOW): window id # 0x1000030
_NET_WM_ICON_NAME(UTF8_STRING) = "Vector_Clock"
WM_ICON_NAME(STRING) = "Vector_Clock"
_NET_WM_NAME(UTF8_STRING) = "Vector_Clock"
WM_NAME(STRING) = "Vector_Clock"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
user specified location: 538, 64
program specified location: 538, 64
program specified size: 2800 by 1926
program specified minimum size: 680 by 0
window gravity: NorthWest`

@denis3509
Copy link

same issue on 23.04

here is syslog:

2023-05-06T13:23:13.848218+03:00 denis-pc gnome-shell[5497]: Could not create transient scope for PID 68253: GDBus.Error:org.freedesktop.DBus.Error.UnixProcessIdUnknown: Process with ID 68253 does not exist.
2023-05-06T13:23:13.873772+03:00 denis-pc gnome-shell[5497]: Can't update stage views actor [:0x55e634412500] is on because it needs an allocation.
2023-05-06T13:23:13.873842+03:00 denis-pc gnome-shell[5497]: Can't update stage views actor [:0x55e63baac5b0] is on because it needs an allocation.

@jonian
Copy link
Member

jonian commented May 7, 2023

I can't replicate the issue on Gnome 44 on arch linux, fedora 38 or ubuntu 23.04.

@Barugon
Copy link

Barugon commented May 7, 2023

Version 71 update fixed it for me.

@Neo-29
Copy link

Neo-29 commented May 7, 2023

not working here on archlinux

Only works with gtk3apps

@denis3509
Copy link

denis3509 commented May 9, 2023

Снимок экрана от 2023-05-09 19-46-47

On the picture you can see that every setting has label "schema not found"

This fixed it for me:

  1. Uninstall extension
  2. Remove the unite settings keys using desktop config editor
  3. Install extension again

@wengole
Copy link

wengole commented May 10, 2023

I too am having this issue, although it's working for maximised windows, but nothing else

@emko
Copy link

emko commented May 11, 2023

was working on 44 up until today, not sure what changed but all my windows have title bars now :(

@wep777
Copy link

wep777 commented May 15, 2023

This fixed it for me:

  1. Uninstall extension
  2. Remove the unite settings keys using desktop config editor
  3. Install extension again

thanks it helped

@cwells
Copy link

cwells commented May 16, 2023

Снимок экрана от 2023-05-09 19-46-47

On the picture you can see that every setting has label "schema not found"

This fixed it for me:

  1. Uninstall extension
  2. Remove the unite settings keys using desktop config editor
  3. Install extension again

Tried this, but dconf always shows "Schema not found" and apps like vscode and slack have titlebars. Fedora 38/GNOME 44.1.

For the record, I also tried the Flatpak fix mentioned.

@Barugon
Copy link

Barugon commented May 16, 2023

I installed this on my notebook but it won't let me enable the plugin. Strangely, the title bar is hidden even without having the plugin enabled (which is wrong) but other features don't work (like having the window buttons in the top bar).

@cwells
Copy link

cwells commented May 16, 2023

For those scrambling for a solution, I installed

https://extensions.gnome.org/extension/4630/no-titlebar-when-maximized/

and this fixed the issue for me, although, as the name suggests, it's not as configurable as Unite.

@alecandido
Copy link

For those scrambling for a solution, I installed

extensions.gnome.org/extension/4630/no-titlebar-when-maximized

and this fixed the issue for me, although, as the name suggests, it's not as configurable as Unite.

Not working for me, at least on Wayland. And unfortunately, not even Unite...

@hyperair
Copy link

This was working for me on 44.0, but it stopped working on 44.1. Checking with xprop, it looks like _MOTIF_WM_HINTS is being set correctly to 0x2, 0x0, 0x2, 0x0, 0x0, but gnome-shell seems to be ignoring that hint now.

Taking a hint from velitasali/gtktitlebar#36 (comment), I tried changing _HIDE_FLAGS like so. Now window decorations disappear, but don't come back. 😕

diff --git a/[email protected]/window.js b/[email protected]/window.js
index f7ae532..87e6f18 100644
--- a/[email protected]/window.js
+++ b/[email protected]/window.js
@@ -19,7 +19,7 @@ const VALID_TYPES = [
 const MOTIF_HINTS = '_MOTIF_WM_HINTS'
 
 const _SHOW_FLAGS = ['0x2', '0x0', '0x1', '0x0', '0x0']
-const _HIDE_FLAGS = ['0x2', '0x0', '0x2', '0x0', '0x0']
+const _HIDE_FLAGS = ['0x2', '0x0', '0x0', '0x0', '0x0']
 
 function isValid(win) {
   return win && VALID_TYPES.includes(win.window_type)

hyperair added a commit to hyperair/unite-shell that referenced this issue Jun 14, 2023
- Change _HIDE_FLAGS to use 0x0 in decorations fields of _MOTIF_WM_HINTS
- Change ServerDecorations.handle to use a boolean flag tracking whether the
  window decorations were previously hidden by united, because mutter now keeps
  `window->decorated` in sync with `window->mwm_decorated`
- Change ServerDecorations.decorated to use `this.win.decorated` since that flag
  is now kept up-to-date. Additionally, win.get_frame_type() now seems to never
  become Meta.FrameType.BORDER

Fixes: hardpixel#324
@olivertzeng
Copy link

same issue

@Lcchy
Copy link

Lcchy commented Aug 15, 2023

Same for me, but the proposed PR (#334) by @hyperair fixed it for me, thanks!

@cwells
Copy link

cwells commented Aug 26, 2023

Mine's been working fine since some recent update (I think GNOME, not Unite).

@jonian
Copy link
Member

jonian commented Oct 15, 2023

Gnome has broken backwards compatibility for extensions. This extension now supports only gnome 45.

@jonian jonian closed this as completed Oct 15, 2023
@jonian jonian added the wontfix label Oct 15, 2023
@koppor
Copy link

koppor commented Mar 13, 2024

IntelliJ still shows the window title bar with v77

image

Should I open a new issue?

@Neo-29
Copy link

Neo-29 commented Mar 13, 2024

It never worked since gnome 45... At least on Wayland.
And as far as it's the future..
I don't know how it can be solved.

Edit : I was wrong.
Working perfectly even on Wayland now 👍

@koppor
Copy link

koppor commented Mar 13, 2024

I played around with other configuration options, restarted IntelliJ. And now it works great!

image

Great suff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.