From dd1db16385d8819eeefcc2f9b8531d807f06401d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Thu, 7 Nov 2024 11:46:57 -0300 Subject: [PATCH] Bidi: Add URL to responses (#2819) --- .../TestExpectations/TestExpectations.local.json | 15 --------------- lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs | 1 + 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index c10f1ec4e..e914d4a21 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -180,21 +180,6 @@ "FAIL" ] }, - { - "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[navigation.spec] *should work with self requesting page*", - "platforms": [ - "darwin", - "linux", - "win32" - ], - "parameters": [ - "webDriverBiDi" - ], - "expectations": [ - "FAIL" - ] - }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", "testIdPattern": "[navigation.spec] *should work when reload causes history API in beforeunload*", diff --git a/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs b/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs index 4694d4f9e..b3335d44b 100644 --- a/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs +++ b/lib/PuppeteerSharp/Bidi/BidiHttpResponse.cs @@ -36,6 +36,7 @@ private BidiHttpResponse(WebDriverBiDi.Network.ResponseData data, BidiHttpReques _data = data; _request = request; Status = (HttpStatusCode)data.Status; + Url = data.Url; } ///