diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index a62419d0d..d6dce64ac 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -11,6 +11,7 @@ on: paths: - '**.yml' - '**.cs' + - '**.json' - '**.csproj' - '**.runsettings' diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index 8ec5f46dc..5a0b033bb 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -92,7 +92,37 @@ }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[browser.spec] *", + "testIdPattern": "[browser.spec] *Browser.isConnected*", + "platforms": [ + "darwin", + "linux", + "win32" + ], + "parameters": [ + "webDriverBiDi" + ], + "expectations": [ + "FAIL" + ] + }, + { + "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", + "testIdPattern": "[browser.spec] *Browser.process*", + "platforms": [ + "darwin", + "linux", + "win32" + ], + "parameters": [ + "webDriverBiDi" + ], + "expectations": [ + "FAIL" + ] + }, + { + "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", + "testIdPattern": "[browser.spec] *Browser.target*", "platforms": [ "darwin", "linux", diff --git a/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs b/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs index f972001a8..7e843bd60 100644 --- a/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs +++ b/lib/PuppeteerSharp.Tests/BrowserTests/UserAgentTests.cs @@ -6,10 +6,6 @@ namespace PuppeteerSharp.Tests.BrowserTests { public class UserAgentTests : PuppeteerBrowserBaseTest { - public UserAgentTests() : base() - { - } - [Test, Retry(2), PuppeteerTest("browser.spec", "Browser.userAgent", "should include WebKit")] public async Task ShouldIncludeWebKit() { diff --git a/lib/PuppeteerSharp/Bidi/BidiBrowser.cs b/lib/PuppeteerSharp/Bidi/BidiBrowser.cs index c2c62bd62..bd36678b9 100644 --- a/lib/PuppeteerSharp/Bidi/BidiBrowser.cs +++ b/lib/PuppeteerSharp/Bidi/BidiBrowser.cs @@ -89,7 +89,7 @@ private BidiBrowser(Core.Browser browserCore, LaunchOptions options, ILoggerFact public override Task GetVersionAsync() => Task.FromResult($"{BrowserName}/{BrowserVersion}"); /// - public override Task GetUserAgentAsync() => throw new NotImplementedException(); + public override Task GetUserAgentAsync() => Task.FromResult(BrowserCore.Session.Info.Capabilities.UserAgent); /// public override void Disconnect() => throw new NotImplementedException();