diff --git a/.github/workflows/on-push-do-docs.yml b/.github/workflows/on-push-do-docs.yml index 1088f7768..26843e88f 100644 --- a/.github/workflows/on-push-do-docs.yml +++ b/.github/workflows/on-push-do-docs.yml @@ -9,7 +9,7 @@ jobs: - name: Setup .NET uses: actions/setup-dotnet@v3 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Run MarkdownSnippets run: | dotnet tool install --global MarkdownSnippets.Tool diff --git a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json index 38951f7a5..30c546b55 100644 --- a/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json +++ b/lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json @@ -122,7 +122,7 @@ }, { "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one", - "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation*", + "testIdPattern": "[navigation.spec] navigation Page.waitForNavigation*should work with clicking on anchor links", "platforms": [ "darwin", "linux", diff --git a/lib/PuppeteerSharp.Tests/NavigationTests/PageWaitForNavigationTests.cs b/lib/PuppeteerSharp.Tests/NavigationTests/PageWaitForNavigationTests.cs index e2b9e0d15..8a02b80f1 100644 --- a/lib/PuppeteerSharp.Tests/NavigationTests/PageWaitForNavigationTests.cs +++ b/lib/PuppeteerSharp.Tests/NavigationTests/PageWaitForNavigationTests.cs @@ -144,19 +144,13 @@ public async Task ShouldWorkWhenSubframeIssuesWindowStop() var frameAttachedTaskSource = new TaskCompletionSource