From 1ac233a662789737faabd7823953b98752c162b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dar=C3=ADo=20Kondratiuk?= Date: Thu, 15 Feb 2024 13:41:06 -0300 Subject: [PATCH] Fix Chrome for testing download URL (#2448) --- .../Browsers/Chrome/ChromeDataTests.cs | 10 +++++----- lib/PuppeteerSharp/BrowserData/Chrome.cs | 2 +- lib/PuppeteerSharp/PuppeteerSharp.csproj | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/PuppeteerSharp.Tests/Browsers/Chrome/ChromeDataTests.cs b/lib/PuppeteerSharp.Tests/Browsers/Chrome/ChromeDataTests.cs index d72bc932b..0d8668032 100644 --- a/lib/PuppeteerSharp.Tests/Browsers/Chrome/ChromeDataTests.cs +++ b/lib/PuppeteerSharp.Tests/Browsers/Chrome/ChromeDataTests.cs @@ -54,19 +54,19 @@ public async Task Usage() public void ShouldResolveDownloadUrls() { Assert.AreEqual( - "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/linux64/chrome-linux64.zip", + "https://storage.googleapis.com/chrome-for-testing-public/113.0.5672.0/linux64/chrome-linux64.zip", BrowserData.Chrome.ResolveDownloadUrl(Platform.Linux, "113.0.5672.0", null)); Assert.AreEqual( - "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/mac-x64/chrome-mac-x64.zip", + "https://storage.googleapis.com/chrome-for-testing-public/113.0.5672.0/mac-x64/chrome-mac-x64.zip", BrowserData.Chrome.ResolveDownloadUrl(Platform.MacOS, "113.0.5672.0", null)); Assert.AreEqual( - "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/mac-arm64/chrome-mac-arm64.zip", + "https://storage.googleapis.com/chrome-for-testing-public/113.0.5672.0/mac-arm64/chrome-mac-arm64.zip", BrowserData.Chrome.ResolveDownloadUrl(Platform.MacOSArm64, "113.0.5672.0", null)); Assert.AreEqual( - "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/win32/chrome-win32.zip", + "https://storage.googleapis.com/chrome-for-testing-public/113.0.5672.0/win32/chrome-win32.zip", BrowserData.Chrome.ResolveDownloadUrl(Platform.Win32, "113.0.5672.0", null)); Assert.AreEqual( - "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/113.0.5672.0/win64/chrome-win64.zip", + "https://storage.googleapis.com/chrome-for-testing-public/113.0.5672.0/win64/chrome-win64.zip", BrowserData.Chrome.ResolveDownloadUrl(Platform.Win64, "113.0.5672.0", null)); } diff --git a/lib/PuppeteerSharp/BrowserData/Chrome.cs b/lib/PuppeteerSharp/BrowserData/Chrome.cs index 6c6708e1a..ca701b0c2 100644 --- a/lib/PuppeteerSharp/BrowserData/Chrome.cs +++ b/lib/PuppeteerSharp/BrowserData/Chrome.cs @@ -19,7 +19,7 @@ internal static async Task ResolveBuildIdAsync(ChromeReleaseChannel chan => (await GetLastKnownGoodReleaseForChannel(channel).ConfigureAwait(false)).Version; internal static string ResolveDownloadUrl(Platform platform, string buildId, string baseUrl) - => $"{baseUrl ?? "https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing"}/{string.Join("/", ResolveDownloadPath(platform, buildId))}"; + => $"{baseUrl ?? "https://storage.googleapis.com/chrome-for-testing-public"}/{string.Join("/", ResolveDownloadPath(platform, buildId))}"; internal static string RelativeExecutablePath(Platform platform, string builId) => platform switch diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj index ab0e8f3d9..28daeec40 100644 --- a/lib/PuppeteerSharp/PuppeteerSharp.csproj +++ b/lib/PuppeteerSharp/PuppeteerSharp.csproj @@ -12,10 +12,10 @@ Headless Browser .NET API PuppeteerSharp - 14.0.0 - 14.0.0 - 14.0.0 - 14.0.0 + 14.1.0 + 14.1.0 + 14.1.0 + 14.1.0 false false embedded