Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features that we would like to have #60

Open
gdubicki opened this issue Jun 4, 2020 · 1 comment
Open

Features that we would like to have #60

gdubicki opened this issue Jun 4, 2020 · 1 comment

Comments

@gdubicki
Copy link
Contributor

gdubicki commented Jun 4, 2020

Hi!

As you have noticed I have started to contribute to this project. I am doing that because I am POCing a service mesh solution for Egnyte that is using this project.

To make it work, apart from #51 and #59, I would also need a few more features, so I would like to ask how do they align with your plans - perhaps you are already working on some of them or on the contrary: you will not even accept PRs with them. Let's have a chat about it. :)

So here it goes, in no specific order:

  • Customizable HAproxy logs format
  • Add custom config fragment to the upstream services frontends - mostly to capture some request headers for enriching the logs
  • Add custom config fragment to the upstream services backends - for various things, like rspirep directives for example,
  • Add a completely custom additional frontend(s) - where we would some custom logic above, f.e. splitting the traffic based on the paths between the upstream backends
  • Listening on the UNIX sockets - as an alternative to above approach we could put the custom loginc into a separate HAproxy instance in front of the sidecar. To minimize the performance penalty we would like it to connect to the sidecar over these sockets.
  • Custom load balancing algorithms? - maybe it doesn't make sense but we are looking for a way to make the load balancing as fair (even) as possible with the distributed load balancers..

So what do you think?

@gdubicki
Copy link
Contributor Author

After discussion with the team we got to the conclusion that our goals may not align with yours and because the pace of your project does not suit our POC needs we will work for now on our fork.

We have highly customized HAproxy configs with a lot of logic in them so we plan to implement a different approach than you. We want to make the HAproxy sidecar use configuration from a template file, with frontends and backends already in it (without the servers) and then fill it in and keep up to date dynamically with service mesh-specific stuff, like userlist controller and backend spoe_back and the servers list.

However if this works out we would strongly prefer to make this an alternative to your HAproxy configuration method and merge our fork back with your project.

Please ping us back with your thoughts. We could also arrange a call to sync and cooperate better. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant