-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/stick_table.c: null pointer dereference suspected by coverity #2518
Labels
type: code-report
This issue describes a code report (like valgrind or coverity)
Comments
chipitsine
added
the
type: code-report
This issue describes a code report (like valgrind or coverity)
label
Apr 4, 2024
haproxy-mirror
pushed a commit
that referenced
this issue
Apr 4, 2024
This bug arrived with this commit: MAJOR: stktable: split the keys across multiple shards to reduce contention At this time, there are no callers which call stktable_get_entry() without checking the nullity of <key> passed as parameter. But the documentation of this function says it supports this case where the <key> passed as parameter could be null. Move the nullity test on <key> at first statement of this function. Thanks to @chipitsine for having reported this issue in GH #2518.
I have just pushed a fix for this. That said, as mentioned in the commit log, there are no callers of stktable_get_entry() which do not test the nullity of passed as parameter to this function (no crashes were possible), even if this is useless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tool Name and Version
coverity
Code Report
Additional Information
No response
Output of
haproxy -vv
The text was updated successfully, but these errors were encountered: