Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSR can lock editor if started when domain reload in progress #97

Open
handzlikchris opened this issue Jul 24, 2023 · 3 comments
Open
Labels
bug Something isn't working needs-refinement Just raw notes, need more info for anyone else to start looking into

Comments

@handzlikchris
Copy link
Owner

Needs confirmation.

File watchers are triggered outside of main thread and potentially code could run even if Unity is doing main reload?

Not sure why that'd lock reloading.

There are some settings in code that'll use LockAssemblyReload - maybe that somehow could contribute?

@handzlikchris handzlikchris added bug Something isn't working needs-refinement Just raw notes, need more info for anyone else to start looking into labels Jul 24, 2023
@brunomikoski
Copy link

Noticed that a couple of times as well. After doing a pull on the project or switching branches, there's a high chance of getting locked while refreshing it.

@handzlikchris
Copy link
Owner Author

Thanks, I'll check it out. I'm assuming you have in-editor reload turned on?

@brunomikoski
Copy link

Nop! Its when I trigger with Ctrl+R gets locked on the Updating Packages popup, I will try to get an Editor log next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-refinement Just raw notes, need more info for anyone else to start looking into
Projects
Status: No status
Development

No branches or pull requests

2 participants