Replies: 5 comments
-
Hey @danives3d The data that is given for the filters is |
Beta Was this translation helpful? Give feedback.
-
Hey, thanks for that, however as said on the other bug I raised (https://github.com/handsontable/handsontable-pro/issues/191#issuecomment-449418954) the HTML content is dependant on a number of variables and decided on in the backend processing within PHP. I'm pleased this has been marked as a feature request though, as it would be good to have the option to display the data in the filters with/without the HTML tags present. |
Beta Was this translation helpful? Give feedback.
-
Thank you again for sharing this idea! I'm moving this topic to Github Discussions. I welcome everyone to discuss this functionality and share your feedback. See you there! |
Beta Was this translation helpful? Give feedback.
-
Addressed in #10756 |
Beta Was this translation helpful? Give feedback.
-
Hi @danives3d I am more than happy to announce that we altered the behavior. Here #10756 is a PR that solves that, and here https://github.com/handsontable/handsontable/releases/tag/14.2.0 you can read more about the changes. |
Beta Was this translation helpful? Give feedback.
-
Description
When using the 'HTML renderer' to show the data inside the table, and enabling the "filter_by_value" dropdown, the HTML markup shows in the dropdown.
Steps to reproduce
Demo
https://jsfiddle.net/0nhradvg/2/
Your environment
Possible Solution
There is a call to
createLabel
in the JavaScript code, that generates the label for the filter. To fix this for my problem, I changed the function to the following:This strips out the HTML from the label. A better solution might be to update the
checkboxRenderer
method to determine if the column is using the HTML renderer and then strip the HTML in the createLabel function.Beta Was this translation helpful? Give feedback.
All reactions