Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNDI server support #25

Open
antoinesd opened this issue Sep 3, 2016 · 4 comments
Open

Add JNDI server support #25

antoinesd opened this issue Sep 3, 2016 · 4 comments
Milestone

Comments

@antoinesd
Copy link
Collaborator

JNDI server is mandatory if we want to add feature like #24 and JTA support.

@johnament
Copy link
Member

I think there's some ways to do the integration without JNDI. Specifically, overriding the Bittronix integration in hibernate to not use JNDI to look up the user transaction. This would be true of other JTA impls out there. Narayana seems to be notorious for its use of JNDI so I'd be cautious to bring it in.

@johnament johnament added this to the Future milestone Sep 3, 2016
@antoinesd
Copy link
Collaborator Author

You're right, we could do without JNDI, but it may imply that we'll have to support specific integration should we have multiple JPA impl support later.
I have to check, but JPA support datasource addition in persistence.xml only thru JNDI lookup.

@johnament
Copy link
Member

Also not true. We can implement PersistenceUnitInfo and provide the DataSource instance as needed.

@johnament
Copy link
Member

Antoine and I spoke about this. We agreed, the best solution is to provide a "simple" JNDI like service for binding beans, probably just named beans, in a look up.

@johnament johnament modified the milestones: 0.4.0, Future Sep 21, 2016
@johnament johnament modified the milestones: 0.5.0, 0.4.0, Future Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants