Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contains/containsInAnyOrder overloading issue #317

Closed
wants to merge 55 commits into from
Closed

fix: contains/containsInAnyOrder overloading issue #317

wants to merge 55 commits into from

Conversation

gokareless
Copy link

@gokareless gokareless commented Sep 5, 2020 •
edited
Loading

Fixes #301.

Caused:

  • Matcher instantiation depends of actual object type

Fix:

  • Adjusted API to work with arrays embedded in objects

The assumption is that whenever we get to the contains(T... items) with an array, the only possible way to get there with an array is by passing Object type reference (because of contains overloaded methods). Therefore we can safely add extra-check for embedded array

@gokareless gokareless mentioned this pull request Sep 6, 2020
Open
@nhojpatrick
Copy link
Member

Going to try and kick start hamcrest, so if you want to get it merged, please rebase from the branch v2.3-candidates.
Still trying to understand how has permissions to perform a release.

@nhojpatrick nhojpatrick force-pushed the master branch 2 times, most recently from 9bc653b to e9f7fc8 Compare February 13, 2022 17:06
Karl-Philipp Richter and others added 25 commits February 13, 2022 19:03
@nhojpatrick
exposed IsEqualCompressingWhiteSpace.string in protected getString in…
f0e2d0e 
… order to facilitate use in subclasses
@nhojpatrick
JavaDoc only @param org.hamcrest.beans
f6abc8c
@nhojpatrick
JavaDoc only @param org.hamcrest.collection
934dd7f
@nhojpatrick
JavaDoc only @param org.hamcrest.comparator
95cf0b2
@nhojpatrick
JavaDoc only @param org.hamcrest.core
ebb9be2
@nhojpatrick
JavaDoc only @param org.hamcrest.object
a393ed9
@nhojpatrick
JavaDoc only @param org.hamcrest.number
877f76a
@nhojpatrick
JavaDoc only @param org.hamcrest.text
facac84
@nhojpatrick
JavaDoc only @param org.hamcrest
450e792
@nhojpatrick
JavaDoc only @param org.hamcrest.integration
869367a
@nhojpatrick
GitHub Actions Default Java/OS first and QA last
9c8ed04
@nhojpatrick
GitHub Actions job needs usage
6294fb5
@nhojpatrick
GitHub Actions concurrency cancel-in-progress
9629b33
@nhojpatrick
Java Code Style EOF org.hamcrest
c884d91
@nhojpatrick
Java Code Style EOF org.hamcrest.beans
c8f5c5e
@nhojpatrick
Java Code Style EOF org.hamcrest.collection
83801b6
@nhojpatrick
Java Code Style EOF org.hamcrest.comparator
11370fe
@nhojpatrick
Java Code Style EOF org.hamcrest.core
0dec084
@nhojpatrick
Java Code Style EOF org.hamcrest.number
c8ff256
@nhojpatrick
Java Code Style EOF org.hamcrest.object
9300b50
@nhojpatrick
Java Code Style EOF org.hamcrest.text
8a2b3b6
@nhojpatrick
Java Code Style EOF org.hamcrest.xml
d150c74
@nhojpatrick
Java Code Style EOF org.hamcrest.io
e1e1ba7
@nhojpatrick
Java Code Style EOF org.hamcrest.internal
738f236
@nhojpatrick
Java Code Style EOF org.hamcrest.integration
614c6e5
nhojpatrick and others added 28 commits February 13, 2022 21:26
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.collection
34c81df
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest
a665d5e
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.beans
02c1d7b
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.core
19a0779
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.number
1414154
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.object
f52954a
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.text
a04fc20
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.internal
6378ae1
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.io
0e6983a
@nhojpatrick
Java Code Style trailing whitespace org.hamcrest.xml
cbaf1d2
@nhojpatrick
Java Code Style squash multiple empty lines
43c0492
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.integration
9dc17e7
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest
57252d1
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.beans
8a73d32
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.collection
972dc77
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.core
6298db7
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.internal
4d3fe7c
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.number
eb09b4a
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.object
541cf0b
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.text
3a4aa57
@nhojpatrick
Java Code Style class/enum/interface padding org.hamcrest.xml
d298634
@nhojpatrick
Java Code Style <format,whitespace>
5d2da07
@nhojpatrick
Java Code Style )whitespace{
5d76642
@nhojpatrick
Java 5 Clean Up
73d89b2 
Remove Unnecessary Boxing
@Andremoniy @nhojpatrick
IsUnmodifiableCollection matcher feature hamcrest#249
0ba3f59
@nhojpatrick
Java 7 Clean Up
3929ae3 
Explicit type argument T can be replaced with <>
@gokareless
- Resolved conflicts
b3e19ce
@gokareless
Merge branch 'fix/anyof-allof-cast' of https://github.com/gokareless/…
7df2387 
…JavaHamcrest into fix/anyof-allof-cast
@gokareless gokareless closed this Feb 15, 2022
@gokareless
Copy link
Author

Adjusted in #380 as per @nhojpatrick request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Casted Type should not matter for containsInAnyOrder
3 participants
@gokareless @nhojpatrick @Andremoniy