Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

将文章的文本内容类型（rawType）判断改为忽略大小写 #5597

Closed
ruibaby opened this issue Mar 26, 2024 · 0 comments · Fixed by #5602
Closed

将文章的文本内容类型（rawType）判断改为忽略大小写 #5597

ruibaby opened this issue Mar 26, 2024 · 0 comments · Fixed by #5602
Assignees
@ruibaby
Labels
area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.14.0

Comments

@ruibaby
Copy link
Member

ruibaby commented Mar 26, 2024 •
edited

你当前使用的版本

2.13.1

描述一下此特性

目前如果 Halo 中有多个编辑器插件，在进入文章编辑页面的时候会根据内容类型（rawType）去查询是否有支持的编辑器，如果没有会给出异常，但判断的过程中没有忽略大小写，就可能导致以下情况：

插件的 rawType 为 MARKDOWN，但文章被其他编辑器编辑之后的 rawType 为 markdown，这个时候就无法使用这个编辑器。

所以建议在判断的时候忽略大小写。

Ref https://bbs.halo.run/d/5229

/area ui
/kind improvement

附加信息

No response
@ruibaby ruibaby added area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. labels Mar 26, 2024
@ruibaby ruibaby added this to the 2.14.x milestone Mar 26, 2024
@ruibaby ruibaby self-assigned this Mar 27, 2024
@ruibaby ruibaby mentioned this issue Mar 27, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this issue Mar 27, 2024
@ruibaby
refactor: ignore case when matching editor raw types (#5602)
c2a7154 
#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.14.x

#### What this PR does / why we need it:

编辑文章匹配编辑器类型时，忽略大小写。

#### Which issue(s) this PR fixes:

Fixes #5597

#### Does this PR introduce a user-facing change?

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruibaby ruibaby

Labels
area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging a pull request may close this issue.

refactor: ignore case when matching editor raw types ruibaby/halo
1 participant
@ruibaby