You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the comment directly above the type declaration for width and height, it says
Can be specified using percentage units.
The typical way this is done is using string values.
Solution
The fix for this is a simple one. The following changes need to be made to the type declaration file in the official @types/reveal.js:
/**
* The "normal" size of the presentation, aspect ratio will be preserved
* when the presentation is scaled to fit different resolutions
*
* Can be specified using percentage units.
*
* @defaultValue `960`
*/
- width?: number;+ width?: number | string;
/**
* The "normal" size of the presentation, aspect ratio will be preserved
* when the presentation is scaled to fit different resolutions
*
* Can be specified using percentage units.
*
* @defaultValue `700`
*/
- height?: number;+ height?: number | string;
I will try to make these changes and make a pull request.
The text was updated successfully, but these errors were encountered:
Problem
The
width
andheight
properties of theconfig
object (of typeReveal.Options
) do not accept strings.It is clear that it is supposed to accept strings for two reasons.
string
values are an expected option. Specifically, inreveal.js
:width
andheight
, it saysThe typical way this is done is using string values.
Solution
The fix for this is a simple one. The following changes need to be made to the type declaration file in the official
@types/reveal.js
:I will try to make these changes and make a pull request.
The text was updated successfully, but these errors were encountered: