Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backgroundTransition should also be inhibited during auto-animate #3346

Open
devkev opened this issue Jan 5, 2023 · 0 comments · May be fixed by #3347
Open

backgroundTransition should also be inhibited during auto-animate #3346

devkev opened this issue Jan 5, 2023 · 0 comments · May be fixed by #3347

Comments

@devkev
Copy link

devkev commented Jan 5, 2023

Slide transitions are disabled during auto-animate, which makes sense because the content is being auto-animated, not transitioned. However, any backgroundTransition is still applied between auto-animate slides, which is very noticeably wrong when using eg. slide.

Reproducer (live demo of problem, live demo of desired behaviour):

<style>
	.slide-background-content {
		background: url('https://placekitten.com/450/300');
		background-size: cover;
	}
</style>

...

<section>
	First Slide
</section>
<section data-auto-animate>
	<h1>Implicit</h1>
</section>
<section data-auto-animate>
	<h1>Implicit</h1>
	<h1>Animation</h1>
</section>
<section>
	Last Slide
</section>

...

<script>
	Reveal.initialize({
		transition: 'slide',
		backgroundTransition: 'slide',
	});
</script>
devkev added a commit to devkev/reveal.js that referenced this issue Jan 5, 2023
@devkev
Disable backgroundTransition during autoAnimate
837ea29 
Fixes hakimel#3346
@devkev devkev linked a pull request Jan 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable backgroundTransition during autoAnimate devkev/reveal.js
1 participant
@devkev