Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix subdivide functions #59

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Fix subdivide functions #59

wants to merge 2 commits into from

Conversation

haesleinhuepf
Copy link
Owner

Fixing the tests in this branch closes #57 . Before merging, remove the _ at the beginning of the three _subdivide functions.

Just run

pytest

Output (excerpt):

=============================================== short test summary info ===============================================
FAILED napari_process_points_and_surfaces/_tests/test_vedo_functions.py::test_subdivide_loop_vedo - assert 3324 < 0
FAILED napari_process_points_and_surfaces/_tests/test_vedo_functions.py::test_subdivide_butterfly - assert 3324 < 0
FAILED napari_process_points_and_surfaces/_tests/test_vedo_functions.py::test_subdivide_linear - assert 3324 < 0
===================================== 3 failed, 16 passed, 216 warnings in 20.56s =====================================

@haesleinhuepf haesleinhuepf marked this pull request as draft February 19, 2023 08:54
@haesleinhuepf haesleinhuepf changed the title add tests for dyfunctional methods WIP: Fix subdivide functions Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some implementations of nppas.subdivide_* produce empty meshes when processing gastruloid
1 participant
@haesleinhuepf