Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hax hangs on a recursive trait with associated type #692

Closed
Nadrieril opened this issue May 30, 2024 · 1 comment · Fixed by #730
Closed

Hax hangs on a recursive trait with associated type #692

Nadrieril opened this issue May 30, 2024 · 1 comment · Fixed by #730
Labels
bug Something isn't working frontend Issue in the Rust to JSON translation

Comments

@Nadrieril
Copy link
Collaborator

Nadrieril commented May 30, 2024 •
edited
Loading 

pub trait Trait1 {
    type T: Trait1;
}

pub trait Trait2: Trait1 {
    type U;
}

Running hax json on this code causes it to hang forever. Removing type U; fixes the issue.
@Nadrieril Nadrieril mentioned this issue May 30, 2024
Closed
@W95Psp W95Psp added the frontend Issue in the Rust to JSON translation label Jun 20, 2024
@W95Psp
Copy link
Collaborator

W95Psp commented Jun 20, 2024 •
edited
Loading

This issue stems from the path_to function doing a depth-first search.
Doing a breadth-first search instead solves this issue, will push a PR soon.

Note that switching to a breadth-first search is not solving issue #686.

Pushed #730

@W95Psp W95Psp mentioned this issue Jun 20, 2024
Merged
@W95Psp W95Psp added the bug Something isn't working label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Issue in the Rust to JSON translation
Projects
No open projects
hax
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): make path_to breadth-first hacspec/hax
2 participants
@W95Psp @Nadrieril