Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub token / permissions for stefanzweifel/git-auto-commit-action #6843

Closed
4 tasks done
t-will-gillis opened this issue May 9, 2024 · 1 comment · Fixed by #6907
Closed
4 tasks done

Add GitHub token / permissions for stefanzweifel/git-auto-commit-action #6843

t-will-gillis opened this issue May 9, 2024 · 1 comment · Fixed by #6907
Assignees
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented May 9, 2024

Overview

The schedule-monthly.yml workflow from earlier this month was not successful. After review, the cause has been traced to insufficient permissions given to the "stefanzweifel/git-auto-commit-action" that conflicts with the hackforla/website's Branch Protection Rules. A fix is needed.

Details

Two other HfLA workflows use the same auto-commit action, and both run without errors. The schedule-monthly.yml automation's failure can be traced back to the workflow's insufficient permissions to bypass the Branch Protection Rules. The following Action Items were tested in a personal repo and appear to address the problem.

Additionally, this issue corrects a minor error in a comment, and removes the manual trigger workflow dispatch: since we do not want this action to be triggered off-schedule.

Action Items

Refer to schedule-monthly.yml.

  • On Line 3, replace 3:00 PDT with the correct time of 4:00 PDT
  • Remove the entirety of Line 7, workflow-dispatch:
  • At lines 15-17, replace:
      # Checkout repo
      - name: Checkout repository
        uses: actions/checkout@v4
    
    with:
      # Checkout repo, and provide authorization token for `stefanzweifel/git-auto-commit-action` below
      - name: Checkout repository
        uses: actions/checkout@v4
        with: 
          token: ${{ secrets.HACKFORLA_ADMIN_TOKEN }}
    
  • Although this workflow affects a GitHub Action, the GHA itself does not require testing (it has been fully tested by previous issues)

Resources/Instructions

@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.5pt Can be done in 3 hours or less labels May 9, 2024
@t-will-gillis t-will-gillis added this to New Issue Approval in Project Board via automation May 9, 2024
@t-will-gillis t-will-gillis added Ready for Prioritization Bug Something isn't working labels May 11, 2024
@t-will-gillis t-will-gillis self-assigned this May 29, 2024
Copy link

Hi @t-will-gillis, we notice that you are assigned to an issue that you authored. Please remember to add the Draft label to this issue while you are working on it.

@t-will-gillis t-will-gillis moved this from New Issue Approval to Prioritized backlog in Project Board May 29, 2024
@t-will-gillis t-will-gillis moved this from Prioritized backlog to In progress (actively working) in Project Board May 29, 2024
Project Board automation moved this from In progress (actively working) to QA May 31, 2024
@HackforLABot HackforLABot moved this from QA to Done in Project Board May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
Project Board
  
Done
1 participant