Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration functionality for System Administrators #6669

Open
thomascate opened this issue Jun 18, 2019 · 7 comments
Open

Improve configuration functionality for System Administrators #6669

thomascate opened this issue Jun 18, 2019 · 7 comments
Labels
Stale Type: Feature Issues that describe a new desired feature

Comments

@thomascate
Copy link

thomascate commented Jun 18, 2019

Currently we're seeing some pain from the system admin side of things managing applications with habitat. Here's what it looks like to try to do the standard "change this one config value" on a habitat app in a ring.

hab config show = show the contents of default.toml not the running config
curl service endpoint = show all computed config as json
hab config apply = Overwrite all non-default values to either their default state or the option in this patch.

Which means, "add this line to the config" is done by
1: Get the default config as toml
2: Get the current config as json
3: Find all values in the json that are not in the toml, this is your current patch set
4: Convert that json hash to a toml hash
5: Add your config change
6: hab config apply with your change (edited)
7: You've currently changed the config on all nodes that do not have a user.toml overriding this. If you want to change those you need to now go find them manually.

At first glance doing a hab config show adding your option and pushing makes sense. However you just moved all your values from one hidden state to another. They were default, they're now configured. So upgrades that change the default won't do what's expected now.

Here's what I would we rather see.

1: hab config show should show the hab config (#5055)
2: hab config patch should exist
3: It should be possible to see a set of default configs, non-default configs, and user.toml overrides
4: the Services endpoint should have on option to send back all of the above in toml instead of json.
5: A helper should exist to set the version string to epoch datetime. So all users don't have to google for this string $(date '+%s') anymore.

With these options changing a config setting goes from 6 tricky steps, to these 2.
1: put key in patch.toml
2: run hab config patch patch.toml $(date %s)

or
1: hit services endpoint for config changes with output set to toml
2: add my values and hab config apply

@irvingpop
Copy link

Also a hab config edit that works like kubectl <object> edit or knife node edit

@christophermaier
Copy link
Contributor

Agreed... there's a lot to be desired in the current workflow.

Here are a handful of related issues:
#3977
#4827
#5032
#5055
#5542

@stale
Copy link

stale bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jul 8, 2020
@christophermaier christophermaier added Type: Feature Issues that describe a new desired feature and removed C-feature labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@stale
Copy link

stale bot commented Jul 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Jul 25, 2021
@themightychris
Copy link
Contributor

Having some sort of hab config patch is still a gap

@stale stale bot removed the Stale label Jul 25, 2021
@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

1 similar comment
@stale
Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Type: Feature Issues that describe a new desired feature
Projects
None yet
Development

No branches or pull requests

4 participants