-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve configuration functionality for System Administrators #6669
Comments
Also a |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
Having some sort of |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
1 similar comment
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you. |
Currently we're seeing some pain from the system admin side of things managing applications with habitat. Here's what it looks like to try to do the standard "change this one config value" on a habitat app in a ring.
hab config show
= show the contents of default.toml not the running configcurl service endpoint
= show all computed config as jsonhab config apply
= Overwrite all non-default values to either their default state or the option in this patch.Which means, "add this line to the config" is done by
1: Get the default config as toml
2: Get the current config as json
3: Find all values in the json that are not in the toml, this is your current patch set
4: Convert that json hash to a toml hash
5: Add your config change
6: hab config apply with your change (edited)
7: You've currently changed the config on all nodes that do not have a user.toml overriding this. If you want to change those you need to now go find them manually.
At first glance doing a
hab config show
adding your option and pushing makes sense. However you just moved all your values from one hidden state to another. They were default, they're now configured. So upgrades that change the default won't do what's expected now.Here's what I would we rather see.
1:
hab config show
should show the hab config (#5055)2:
hab config patch
should exist3: It should be possible to see a set of default configs, non-default configs, and user.toml overrides
4: the Services endpoint should have on option to send back all of the above in toml instead of json.
5: A helper should exist to set the version string to epoch datetime. So all users don't have to google for this string $(date '+%s') anymore.
With these options changing a config setting goes from 6 tricky steps, to these 2.
1: put key in patch.toml
2: run
hab config patch patch.toml $(date %s)
or
1: hit services endpoint for config changes with output set to toml
2: add my values and
hab config apply
The text was updated successfully, but these errors were encountered: