Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent Services #1973

Closed
reset opened this issue Mar 21, 2017 · 4 comments
Closed

Concurrent Services #1973

reset opened this issue Mar 21, 2017 · 4 comments
Assignees
Labels
Epic Focus:Hab-Automate Relevant to the A2 Chef Team Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance

Comments

@reset
Copy link
Collaborator

reset commented Mar 21, 2017

The main thread of the supervisor currently "schedules" time to each service by allowing each service to "tick" on every server tick. This is a great first step to moving logic for servicing a service to the Service struct itself, but we now run the risk of blocking execution of other services if a service tick runs for a longer than usual period of time and, in a worst case, indefinitely blocking execution.

A service "tick" includes operations for running external code in the form of hooks and this is where the potential for blocking execution lies. We need to refactor the Manager and Service relationship so the Service executes from within it's own thread and receives information from the Manager when it's ready over a channel. Making this change may also require some refactorings to the way the http-gateway reads information about services.

This refactor is a requirement for backgrounding long running hooks (ie. Smoke Test hook)

@reset
Copy link
Collaborator Author

reset commented Aug 3, 2017

This is a pre-requisite of #2680

@eeyun eeyun added this to the Help Wanted milestone Aug 15, 2017
@reset reset removed the E-mentored label Oct 17, 2017
@reset reset removed this from the Help Wanted milestone Oct 17, 2017
@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Apr 3, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Type: Chore Issues for general code and infrastructure maintenance and removed A-supervisor labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@stale
Copy link

stale bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Oct 1, 2022
@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically closed after being stale for 400 days. We still value your input and contribution. Please re-open the issue if desired and leave a comment with details.

@stale stale bot closed this as completed May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Focus:Hab-Automate Relevant to the A2 Chef Team Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Stale Type: Chore Issues for general code and infrastructure maintenance
Projects
None yet
Development

No branches or pull requests

4 participants