Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improve error message during generation of configuration #1677

Open
moretea opened this issue Jan 26, 2017 · 3 comments
Open

[UX] Improve error message during generation of configuration #1677

moretea opened this issue Jan 26, 2017 · 3 comments
Labels
Focus :Plan Build Focus: Studio Related to the Habitat Studio (core/hab-studio) component Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component

Comments

@moretea
Copy link

moretea commented Jan 26, 2017

If one makes a typo in a config file, the supervisor prints out a Rust Result directly.

Maybe the supervisor should just abort if the generation of configuration files fails; the current behaviour might lead to starting mis-configured services.

How to reproduce

  1. Create an empty plan.sh and a config/some_file
  2. Fill config/some_file with:
aaa{{ref}aaa

This will generate an error similar to:

php-redis.default(SR): Failed to write service configuration: hab-sup(SC)[src/manager/service/config.rs:161:27]: TemplateError(TemplateError { reason: InvalidSyntax, template_name: Some("phpfpm.conf"), line_no: Some(6), column_no: Some(32) })
@rsertelon
Copy link
Contributor

This is also linked to and could be fixed with #1137

@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

@stale stale bot added the Stale label Apr 3, 2020
@christophermaier christophermaier added Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component Focus: Studio Related to the Habitat Studio (core/hab-studio) component and removed A-supervisor labels Jul 24, 2020
@stale stale bot removed the Stale label Jul 24, 2020
@rahulgoel1 rahulgoel1 removed the V-devx label Jul 23, 2021
@stale
Copy link

stale bot commented Oct 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus :Plan Build Focus: Studio Related to the Habitat Studio (core/hab-studio) component Focus:Supervisor Related to the Habitat Supervisor (core/hab-sup) component
Projects
None yet
Development

No branches or pull requests

6 participants