Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if waved cannot find public/private dir #2130

Open
mturoci opened this issue Sep 7, 2023 · 3 comments · May be fixed by #2213
Open

Raise error if waved cannot find public/private dir #2130

mturoci opened this issue Sep 7, 2023 · 3 comments · May be fixed by #2213
Labels
feature Feature request good first issue Contributions welcome! server Related to server

Comments

@mturoci
Copy link
Collaborator

mturoci commented Sep 7, 2023

Is your feature request related to a problem? Please describe

Debugging public/private dir configuration is painful currently, because if the path is not correct, the operation fails silently and waved starts nonetheless.

Describe the solution you'd like

Notify the user about the inaccessible path during waved startup.
@mturoci mturoci added server Related to server feature Feature request labels Sep 7, 2023
@mturoci mturoci added the good first issue Contributions welcome! label Oct 10, 2023
@kaitlyncliu
Copy link

Hi I would like to work on this!

@mturoci
Copy link
Collaborator Author

mturoci commented Nov 28, 2023

Go ahead and good luck then @kaitlyncliu!

92ammarraza pushed a commit to kellyycha/wave that referenced this issue Dec 6, 2023
fix: raise error if waved cannot find public/private dir h2oai#2130
b9e5a07
92ammarraza pushed a commit to kellyycha/wave that referenced this issue Dec 6, 2023
fix: added a fucntion to check if the dir is accessible, issue h2oai#…
bf61b1c 
…2130
@92ammarraza 92ammarraza linked a pull request Dec 6, 2023 that will close this issue
Open
5 tasks
@kaitlyncliu
Copy link

Hi, just wanted to update that I am working with @92ammarraza on this issue for a class project so he is making the PR!

ShrirangB added a commit to ShrirangB/wave that referenced this issue Dec 22, 2023
@ShrirangB
Fixed issue Raise error if waved cannot find public/private dir h2oai…
18a6dd2 
…#2130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request good first issue Contributions welcome! server Related to server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Raise error if waved cannot find public/private dir #2130 kellyycha/wave
2 participants
@mturoci @kaitlyncliu