-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gulp exits zero if a promise is rejected with no value #1327
Comments
Can you test this with gulp 4.0 and see if it still happens? |
@phated: nope, it's fixed: I just spent waaaaay too much time proving it. Is there documentation on gulp 4, and how to upgrade to it? |
I spent wayyyy too much time before accidentally "solving" it (passing an arbitrary string to reject method), then came here to see if anybody else encountered this bug, and found this issue - @phated, it could be really helpful documenting it somewhere (as you said, it won't work in 3.x, ever). |
Hi,
First, versions:
After a bit of debugging, I've discovered that this code causes gulp to exit 1 (as it should):
Where as this causes it to exit 0, when it should exit 1:
I hope I'm not submitting a duplicate, I couldn't find one. Thanks!
The text was updated successfully, but these errors were encountered: