Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change app ID #35

Open
SGarno opened this issue Nov 4, 2020 · 4 comments
Open

Unable to change app ID #35

SGarno opened this issue Nov 4, 2020 · 4 comments

Comments

@SGarno
Copy link

SGarno commented Nov 4, 2020

Device:

  • OS: Windows
  • Version: 10
  • Go Version: 1.15

Describe the bug
Changing the app ID in guark.yaml to a value with more or less than 9 characters, seems to cause a compilation error:

D:\Development\tm1compare\app>guark build
✔ Delete existing dest: Y
✔ Delete existing dest: Y
✔ Build Initialized 🔨
✔ Build App UI 🎨
✔ Build Embeded Files 🗃️
✔ Build Meta Files ℹ️
⠧ Building Windows App...# carpedatuminc.com/sgarno/tm1compare
C:/TDM-GCC-64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: $WORK\b001\exe\a.out.exe: .rsrc merge failure: corrupt .rsrc section
✔ Build Windows App 🗔

To Reproduce
Steps to reproduce the behavior:

  1. Edit guark.yaml, change GuarkDemo to GuarkDemoX
# App id must be unique.
id: GuarkDemoX
  1. Execute guark build
  2. Repeat item 1, but change GuarkDemo to GuarkDem
# App id must be unique.
id: GuarkDem
  1. Execute guark build

Expected behavior
Successful compilation

Additional Information
Not sure what the comment that App id must be unique is referring to. Unique to what?

@melbahja
Copy link
Member

melbahja commented Nov 5, 2020

unique app id used to install the app in windows: Program Files/{appID}
for linux based systems install path is /usr/share/{appID}

I will try fo find or rent a windows machine to test this weird behavior.

@melbahja
Copy link
Member

melbahja commented Nov 6, 2020

I got a windows test machine, I'm unable to reproduce this issue.

I changed the ID to 3 chars and it works..

Can you double check again?

@SGarno
Copy link
Author

SGarno commented Nov 6, 2020

I tried it after changing it to Chrome in guark.yaml, and it worked....so was like whua?? Ha! Turns out this is also related to webview. ....Interesting.

@melbahja
Copy link
Member

Did you still experiencing this issue with webview engine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants