Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented a Delete functionality for KeyValue #2033

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implemented a Delete functionality for KeyValue #2033

wants to merge 6 commits into from

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 586fda0 to f0176af Compare July 17, 2024 15:56
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 5beeb63 to c8b6ae5 Compare July 17, 2024 16:13
@pxp928 pxp928 requested a review from jeffmendoza July 19, 2024 16:08
@nathannaveen nathannaveen requested a review from pxp928 July 19, 2024 20:20
jeffmendoza
jeffmendoza requested changes Aug 2, 2024
View reviewed changes
pkg/assembler/backends/keyvalue/path.go Show resolved Hide resolved
pkg/assembler/backends/keyvalue/certifyVuln.go
}

// Update the entity in the KeyValue store
return c.kv.Set(ctx, col, id, newLinks)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. It is replacing the vuln and package structs/nodes with a string array. You need to get / modify / and set those structs. Should probably use the setkv() helper (https://github.com/guacsec/guac/blob/main/pkg/assembler/backends/keyvalue/backend.go#L248)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this review! This review made me think deeply, and I realized that I was setting the key value wrong, so I have fixed that, as well as modifying the structs and not replacing them.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not right and doing the same thing.

@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch 2 times, most recently from c5f0927 to 2980fe7 Compare August 12, 2024 19:58
@nathannaveen
Copy link
Contributor Author

After some thought, I realize that the code is going to require a lot of changes. So I am going to be converting this to a draft PR.

This is mainly because of a deep dive into the comment #2033 (comment) by @jeffmendoza.

@nathannaveen nathannaveen marked this pull request as draft August 12, 2024 20:47
@nathannaveen nathannaveen marked this pull request as ready for review August 13, 2024 18:11
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 8708cb0 to 6c01d0c Compare August 13, 2024 18:15
@pxp928
Copy link
Collaborator

pxp928 commented Oct 11, 2024

@nathannaveen this needs a rebase

@nathannaveen
Include delete functionality for KeyValue
4d50638 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete Certify Vuln
72fc906 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete hasSLSA
06c2786 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete hasSBOM
5ea80ea 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Fix tests
c7e683c 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Improved error messages
e8c024f 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 6c01d0c to e8c024f Compare October 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] KeyValue add delete node functionality
4 participants
@nathannaveen @pxp928 @mihaimaruseac @jeffmendoza