Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report not displaying unless --verbose specified #254

Open
chimericdream opened this issue Aug 27, 2014 · 25 comments
Open

Report not displaying unless --verbose specified #254

chimericdream opened this issue Aug 27, 2014 · 25 comments

Comments

@chimericdream
Copy link

My gruntfile includes the option to display gzip reports for all of my uglified JS files, but they are no longer showing up. It looks like the commit below changed the output to write only on verbose, but I'd think if the report was explicitly specified it should show up regardless.

4944e2c

I can understand wanting to have less output, but if someone specifies that the report should be displayed, it shouldn't require --verbose to show it.

@chimericdream chimericdream changed the title Report not displaying at all Report not displaying unless --verbose specified Aug 27, 2014
@chimericdream
Copy link
Author

Here is the uglify options block from my gruntfile:

options: {
    compress: {
        drop_console: true,
        screw_ie8: true,
        warnings: false
    },
    mangle: {
        except: ['jQuery', 'Backbone']
    },
    report: 'min'
},

@vladikoff
Copy link
Member

Related #249

@XhmikosR
Copy link
Member

I, too, believe the output file should be logged in without verbose.

@chimericdream
Copy link
Author

Even beyond that, the report is not displayed at all. Looking at the output again, I noticed that specifying report: 'min' or report: 'gzip' does not produce any report whatsoever, regardless of whether --verbose was specified.

@vladikoff Should I update the title of the issue to reflect that reports are no longer being generated at all, regardless of verbosity?

@commadelimited
Copy link

+1 to fixing this issue. The docs don't mention any requirement for verbose mode, meaning many will assume it's broken.

@Schinkentanz
Copy link

+1

@zachleat
Copy link

+1 for non-verbose report output. The default report might be better as falsy, with non-empty values for report showing non-verbose output.

@vsn4ik
Copy link
Contributor

vsn4ik commented Dec 9, 2014

👍

meschbach referenced this issue Jan 15, 2015
Files created are logged on verbose
@roncli
Copy link

roncli commented Jan 15, 2015

I commented on 4944e2c a few months ago that I wanted to do a PR to make an option to have the minification data in the general log and not in grunt's verbose log. Based on the feedback, I did not.

My opinion is that the minification data is significant enough to not have to use grunt --verbose AND add an option to the gruntfile just to get it.

@XhmikosR
Copy link
Member

IMO this is important info and should be shown without a switch at all.

@ronnyhartenstein
Copy link

+1 for @XhmikosR and @zachleat I miss it, thought it is a bug.

@meschbach
Copy link
Contributor

I submitted a pull request (#288 above) which will hopefully be accepted and make both parties happy.

@dominikwilkowski
Copy link

👍 for a fix

1 similar comment
@deveras
Copy link

deveras commented May 23, 2015

👍 for a fix

@joaovieira
Copy link

👍

One has to google where did the report output go to find that the report option is useless now without being verbose (at least update the docs). I believe people don't want two switches to turn this report on. Plus, we don't need entire verbose info if I just want to get the gzip report..

@janrembold
Copy link

+1 for a fix

@j-walker23
Copy link

Hey all. Wondering if someone knows the answer to this.

Did this task use to say the difference in size by default? I swear i used to see it, but i can't remember.
If so, what were the reasons to take it out? Mostly just curious since i am assuming taking it out was due to other reasons i am ignorant to.

@2ge
Copy link

2ge commented Sep 28, 2015

got v0.9.2 and info is still not displayed :(

@MarcosBL
Copy link

+1 to fix this issue

@Jerska
Copy link

Jerska commented Dec 14, 2015

👍

@suabo
Copy link

suabo commented Aug 11, 2016

This Bug ist still there... ist there nobody to fix it?

@meschbach
Copy link
Contributor

There are differing opinions on what it means to fix it, including mine in #288, which was accepted on March 4th, 2016. The fix was then reverted in #419 in the middle of July.

@suabo
Copy link

suabo commented Aug 11, 2016

If i do my task i get no report. But i think there should be a short report about how many files and maybe the size of files before and after in sum should be displayed like in cssmin! Otherwise the report option make no sense. If you set it to 'none' the task can be quiet but not if it is set to min or gzip.

@XhmikosR
Copy link
Member

Sorry for that. It seems @vladikoff merged that PR fast. I reverted that PR. Please check and let me know so that I cut a new patch release.

@suabo
Copy link

suabo commented Aug 14, 2016

PLease can anyone check this, so that the changes can be released. Seems im to stupid to check that out or there is still no reporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests