Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dart-Sass #239

Open
vikmn opened this issue Nov 15, 2017 · 5 comments
Open

Support for Dart-Sass #239

vikmn opened this issue Nov 15, 2017 · 5 comments

Comments

@vikmn
Copy link

vikmn commented Nov 15, 2017

The readme mentions the requirement of ruby and sass for the purpose of this task. However it appears that the newer version of Sass is being moved away from ruby and uses dart. Also the newer version is available as an npm package @ github.com/sass/dart-sass. Will this task work out of the box without ruby if the new package was to be used?

@nex3
Copy link

nex3 commented Mar 23, 2018

Dart Sass is in Release Candidate phase now, with a full release probably coming next week. I'd be happy to send a pull request to add support for it if a maintainer can help me land it.

@laurenhamel
Copy link

laurenhamel commented May 31, 2018

Checking in to see if there's any update on this issue since the 1.5.0 release of Dart Sass. I'm currently using the latest release of grunt-contrib-sass with latest dart-sass. So far, I've encountered some errors with compiling .scss files and ran into issues with the grunt-contrib-sass options versus the dart-sass cli (i.e., --[no-]source-map instead of --sourcemap, --style only accepts compressed or expanded, no --cache option, etc.). An update to this package would be helpful since the Ruby Sass version has been deprecated.

@laurenhamel
Copy link

I submitted a PR for a proposed upgrade to using Dart Sass. I left the integration tools (travis/appveyor) intact since you guys will likely need to review that stuff based on the proposed changes I'm suggesting. In the meantime, I've also created grunt-dart-sass, which uses the Dart Sass JavaScript API, for anyone who may land here looking for the same thing I was.

@ve3
Copy link

ve3 commented Jun 8, 2019

@laurenhamel It seems that this has not been merged? #244

@laurenhamel
Copy link

@ve3, no, it was not. The PR I submitted (#244) was closed without review because of "too many changes," and it seems that this project is moving in the direction of an implementation-agnostic grunt task. If you're looking for a an immediate solution using Dart Sass, refer to my previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants