Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why it was added again peerDependencies ? #248

Open
pine opened this issue Mar 5, 2016 · 4 comments
Open

Why it was added again peerDependencies ? #248

pine opened this issue Mar 5, 2016 · 4 comments

Comments

@pine
Copy link

pine commented Mar 5, 2016

Hi. I think peerDependencies is deprecated but added again in the package.json.

Remove peerDeps. Ref gruntjs/grunt#1116: 4557d04
Add grunt >=0.4.0 as a peerDep: a368347

If it has grunt >= 0.4.0 in peerDependencies, I can't use Grunt v1.0.0-rc1 with npm 2.x.

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants grunt@>=0.4.0

In this environment,

$ node --version
v4.3.2
$ npm --version
2.14.12
$ nvm --version
0.23.3

Thank you.

@vladikoff
Copy link
Member

Thanks for the issue. this is strange @shama 😕

@shama
Copy link
Member

shama commented Mar 6, 2016

Wow that is annoying. They are added back in to be consistent with our recommendations. Until grunt is no longer an actual peer dep. >=0.4.0 should match 1.0.0-rc1 but if it doesn't... sigh. I guess we'll have to nuke them or just never release pre-release versions.

@pine
Copy link
Author

pine commented Mar 6, 2016

Hello @shama,

>=0.4.0 should match 1.0.0-rc1 but if it doesn't... sigh.

That's right! I thought that >=0.4.0 matchs 1.0.0-rc1 but ...
I hope that Grunt v1.0 is released quickly.

Thank you.

@zappan
Copy link

zappan commented May 25, 2017

@shama Grunt passed v1.0.0. any chance of getting this peer dep updated? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants