Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore metadata to the furl module #129

Open
gruns opened this issue Jul 2, 2020 · 5 comments
Open

Restore metadata to the furl module #129

gruns opened this issue Jul 2, 2020 · 5 comments

Comments

@gruns
Copy link
Owner

gruns commented Jul 2, 2020

Before v2.0.0:

>>> import furl
>>> print(furl.__version__)
'2.0.0'

With v2.1.0:

>>> import furl
>>> print(furl.__version__)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'furl' has no attribute '__version__'

The other metadata attributes are missing, too: __version__, __license__, etc.

@gruns gruns changed the title Restore metadata to the furl object Restore metadata to the furl module Jul 2, 2020
@yellalena
Copy link

hey can I work on this?

@ThatXliner
Copy link

ThatXliner commented Oct 2, 2020

I guess they just removed those variables from the __init__.py and put it in the __version__.py. They might need to add an __all__ variable to let the user get this metadata.

@gruns
Copy link
Owner Author

gruns commented Oct 2, 2020

Absolutely! Pull requests welcome.

@ThatXliner Yep; the metadata was lost in the migration to __version__.py

@ThatXliner
Copy link

ThatXliner commented Oct 2, 2020

@gruns The main code is in furl.py, right? So I just need to add __all__ = ["furl", "__version__"] unless some of the implementation are in the other files.

@gruns
Copy link
Owner Author

gruns commented Oct 6, 2020

Not sure; that might do it.

If

>>> import furl
>>> furl.__version__
2.1.0

works, you did it 😃

ThatXliner added a commit to ThatXliner/furl that referenced this issue Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants