-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An RPC proto oneof field documents the field not used in the path as an optional request parameter #2494
Comments
Thanks for the bug report! We've discussed this a bit on other channels and I think there's definitely something we can do here. The case we're interested in is when one of the fields of a |
@johanbrandhorst I am interested to contribute to this issue. Let me know if I can pick this up. |
Hi, yes, please feel free to start work, I don't know anyone else that is working on this. |
@johanbrandhorst |
Hi @momom-i, yes, feel free to start work on this :). I think the ask is to ensure that if one of fields in a |
Steps you follow to reproduce the error:
With the annotations above, two "separate" endpoints are defined in the output:
With the non-path parameter of the oneof listed as an optional query parameter, which is incorrect:
What did you expect to happen instead:
I expect a single GET endpoint defined with 2 path parameters listed with oneof as required (not both, and nothing listed as a request parameter).
Your answer here.
What's your theory on why it isn't working:
I suspect there is simply no code to deal with the protobuf oneof type.
The text was updated successfully, but these errors were encountered: