Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Card docs #324

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Nov 3, 2021

Adjusts card docs based on updates made in grommet/grommet#5762

@@ -86,13 +93,6 @@ export default () => (
<Example>"small"</Example>
</PropertyValue>
</Property>

<Property name="card.hover.container.extend">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this still possible, via

kind={{
    hover: theme.card.hover?.container,
    ...theme.card.container,
}}

Copy link
Collaborator Author

@taysea taysea Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extend does not apply at the moment.

@taysea taysea requested a review from jcfilben April 15, 2022 17:45
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look fine. It looks like we need to add this theme prop to themes/base.d.ts in Grommet.

@jcfilben
Copy link
Collaborator

base.d.ts has been updated to include card.container.extend in grommet/grommet#6203

It looks like yarn.lock just needs updated and then we can merge this

@jcfilben
Copy link
Collaborator

Looks like there is still a merge conflict with yarn.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants