New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of a formatters interface #178
Comments
Hey @Drowze! Thank you for the kind words and your willingness to contribute to the project! This formatter I went through your changes and think there are two aspects: one being about decoupling I have been usually suggesting |
Hello @grodowski 馃憢
First of all, I'd like to say thank you for this great project! I've been using it extensively for the past year on the CI of a few internal repositories and it's quite handy to me and my peers. Great work!
After some time with undercover however, I feel that it lacks a formatter interface. I see on this line a comment that even hints that a formatter interface was planned: https://github.com/grodowski/undercover/blob/master/lib/undercover/result.rb#L63
# TODO: create a formatter interface instead and add some tests.
That said, this is something that concerns me so I'd like to help 馃槃 I've been actually working a bit on some changes (which you can check here) that aim de-couple the
Result
fromFormatter
- thus allowing other formatters to be used.I would personally like to see this being possible (which I think is exactly how rubocop handle this):
I'm a bit concerned though as this would be a slightly big change - so I'd like to ask your opinion before opening my first PR on this project. What do you think @grodowski? Can I go ahead and try to tackle this one? 馃槃
The text was updated successfully, but these errors were encountered: