-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove friction when adding a new film #67
Comments
yes, this could be a better solution than we have now. Don't forget PRs are always welcome! ;)
Will think about how to improve it. Thanks for comment
If you want to run npm locally, so yes you need api key.
Actually it almost how it works now. But we use Codeship instead of Travis. |
With #63 we have automatic ratings, but this includes way more steps required to go through when you add a new movie.
My 2 cents:
storage.js
from_prebuilt.md
- The user is going to add the IMDb link when adding a movie. We could simply parse the file and add this intostorage.js
Contributing.md
more understandable. I had to hunt for_prebuilt.md
Then run npm run build-movies
-> This is assuming that whoever is adding the movie knows how to use npm to install dependencies. Correct me if I'm wrong, but the user needs a local api-key?User modifies prebuilt.md and sends PR
>Accept PR
> CI automatically generatesstorage.js
from_prebuilt.md
. Then it runs npm build-movies and deploys it back to branch.The text was updated successfully, but these errors were encountered: