-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore or warn about models referencing non-existent internal Rails tables by default #77
Comments
Personally, I think that was not the best idea to ignore them by default, because it is possible to miss some flaws even for them (despite being developed by smart people etc, maybe you modified them by yourself, who knows?), for example, duplicate indexes or As for mentioned models, the same thought. As an alternative, if you are not using |
As I said, "Maybe it is too much to ignore them". And I am fine with the ideas like "And those warnings will disappear.". When it would be only a warning. But it is an error, stopping execution of following tasks. |
Yes, I mean "errors". They will disappear. |
I know what you mean. But in the most cases it still produces error on new projects, before I start to use those Models and features. With warnings it would be OK, because all following tasks would run as they should. |
On Rails 7 (and probably on Rails 6 too) with new app I will get following errors, when I run
bundle exec rails active_record_doctor:undefined_table_references
:I think it is intended, but in many cases it should not be an error, because most new apps are not using those features a long time, if ever at all (e.g.
InboundEmail
).The documentation says that those tables are ignored by default for other tasks.
Maybe it is too much to ignore them in this case, then it should be only a warning?!
Probably it is hard to detect, if those models are used and only in this case to produce an error?
The text was updated successfully, but these errors were encountered: