Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md instructions throws errors #47

Open
dimitrisfasoulas opened this issue Jun 7, 2021 · 0 comments
Open

CONTRIBUTING.md instructions throws errors #47

dimitrisfasoulas opened this issue Jun 7, 2021 · 0 comments
Labels

Comments

@dimitrisfasoulas
Copy link

🐛 Bug Report

CONTRIBUTING.md seems to be copied from another project, and its instructions fail.

Running yarn lint will fail since eslint-config-prettier been updated (separate issue here)

Changing the config so it works, throws 36756 problems

Also running yarn test fails with Usage Error: Couldn't find a script named "test".

To Reproduce

Steps to reproduce the behavior:

Fork or clone the repo,

Follow CONTRIBURING.md instructions and run yarn lint and yarn test

Expected behavior

Both commands should run, without errors.

Run npx envinfo --system --binaries --npmPackages smooth-doc,gatsby,react,react-dom --markdown --clipboard

Paste the results here:

## System:
 - OS: Linux 5.4 Ubuntu 20.04.1 LTS (Focal Fossa)
 - CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
 - Memory: 1.56 GB / 7.77 GB
 - Container: Yes
 - Shell: 5.8 - /usr/bin/zsh
## Binaries:
 - Node: 14.15.1 - ~/.nvm/versions/node/v14.15.1/bin/node
 - Yarn: 2.4.1 - ~/.nvm/versions/node/v14.15.1/bin/yarn
 - npm: 7.5.3 - ~/.nvm/versions/node/v14.15.1/bin/npm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants