Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] Support deprecated argument on query arguments #3537

Open
JulienVerbrugge opened this issue Feb 20, 2024 · 3 comments
Open

[graphiql] Support deprecated argument on query arguments #3537

JulienVerbrugge opened this issue Feb 20, 2024 · 3 comments

Comments

@JulienVerbrugge
Copy link

GraphiQL support for deprecated fields is great but it does not cover the query arguments.

Depreciation on field
image

Depreciation on argument
image

Since GraphQL arguments object handle depreciation, it could be great to extend this functionality to argument.
From type/definition.ts

export interface GraphQLArgumentConfig {
  description?: Maybe<string>;
  type: GraphQLInputType;
  defaultValue?: unknown;
  deprecationReason?: Maybe<string>;
  extensions?: Maybe<Readonly<GraphQLArgumentExtensions>>;
  astNode?: Maybe<InputValueDefinitionNode>;
}

Thanks

@JulienVerbrugge JulienVerbrugge changed the title [graphiql] <Support deprecated argument on interface> [graphiql] Support deprecated argument on interface Feb 20, 2024
@JulienVerbrugge JulienVerbrugge changed the title [graphiql] Support deprecated argument on interface [graphiql] Support deprecated argument on ui Feb 20, 2024
@acao
Copy link
Member

acao commented Feb 20, 2024

ah yes this is a new spec feature as of a few years ago, thanks for bringing it up!

I would invite you to contribute a fix, but the dev tooling is kinda annoying at the moment, so proceed at your own risk haha. Happy to help with instructions - just yarn at root first then yarn tsc at root, then simultaneously yarn dev in graphiql-react and yarn dev-graphiql at the root 😆 eventually we will have pnpm and turborepo, but for now bless this mess haha

@acao acao changed the title [graphiql] Support deprecated argument on ui [graphiql] Support deprecated argument on query arguments Feb 20, 2024
@brodin
Copy link

brodin commented Mar 19, 2024

👋 @acao – would you say that the dev tooling situation has improved? I also came here looking for this 👀

@acao
Copy link
Member

acao commented Mar 19, 2024

no it has not, for years, but that doesn't stop contributors almost daily! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants