Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] codemirror-graphql depends on @types/codemirror@^0.0.90 but uses codemirror@^5.65.3 #3525

Open
1 task done
benjie opened this issue Feb 1, 2024 · 1 comment

Comments

@benjie
Copy link
Member

benjie commented Feb 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

codemirror-graphql depends on @types/codemirror@^0.0.90 but has peerDependency on codemirror@^5.65.3

Expected Behavior

Would expect that it uses @types/codemirror@npm:^5.60.9 or similar?

Steps To Reproduce

yarn add graphiql, then look at yarn.lock - two versions of @types/codemirror are installed, one is 0.0.90.

Environment

  • GraphiQL Version: 3.1.0
  • OS: Ubuntu 22.04
  • Browser: Irrelevant
  • Bundler: Irrelevant
  • react Version: Irrelevant
  • graphql Version: Irrelevant

Anything else?

package.json
yarn.lock.txt (.txt so GitHub allows upload)

@acao
Copy link
Member

acao commented Feb 1, 2024

yes this is a longstanding issue and I have tried to fix it several times, it's not undoable just complicated. the contrib codemirror 5 types have a lot of issues in general. i highly recommend using our new codemirror 6 mode instead, which has native types!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants