Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a small and/or read-optimized string for internal field representation #819

Open
LegNeato opened this issue Dec 10, 2020 · 0 comments · May be fixed by #1247
Open

Use a small and/or read-optimized string for internal field representation #819

LegNeato opened this issue Dec 10, 2020 · 0 comments · May be fixed by #1247
Labels
enhancement Improvement of existing features or bugfix k::performance Related to performance k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Milestone
0.17.0

Comments

@LegNeato
Copy link
Member

we store the name of each field as a string. Fields are likely on average pretty short (think "id", "name", etc) and are read more than written. We should investigate using a small and/or read-optimized string for internal field representation instead of std's String.
@LegNeato LegNeato added enhancement Improvement of existing features or bugfix help wanted easy k::performance Related to performance good-first-issue labels Dec 10, 2020
andrisak added a commit to andrisak/juniper that referenced this issue Mar 21, 2021
@andrisak
Use smartstring for name of field (graphql-rust#819).
30263ad
LegNeato added a commit that referenced this issue Mar 30, 2021
@andrisak @LegNeato
Use smartstring for name of field (#819). (#899)
0de6317 
Co-authored-by: Christian Legnitto <[email protected]>
@audunhalland audunhalland linked a pull request Mar 11, 2024 that will close this issue
Open
@tyranron tyranron added this to the 0.17.0 milestone Apr 9, 2024
@tyranron tyranron added k::refactor Refactoring, technical debt elimination and other improvements of existing code base and removed help wanted easy good-first-issue labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing features or bugfix k::performance Related to performance k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

feat: use ArcStr for storing strings in Schema audunhalland/juniper
2 participants
@LegNeato @tyranron